Skip to content

cli/command: move prompt utilities to separate package - #5952

Merged
thaJeztah merged 4 commits into
docker:masterfrom
thaJeztah:move_prompt_utils_step1
Apr 11, 2025
Merged

cli/command: move prompt utilities to separate package#5952
thaJeztah merged 4 commits into
docker:masterfrom
thaJeztah:move_prompt_utils_step1

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

See individual commits for details; may be doing some follow-ups after this.

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztahthaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 22, 2025
@thaJeztahthaJeztah added this to the 28.0.3 milestone Mar 22, 2025
@codecov-commenter

codecov-commenter commented Mar 22, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 67.94872% with 25 lines in your changes missing coverage. Please review.

Project coverage is 59.12%. Comparing base (8633197) to head (b74b7b3).
Report is 15 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5952 +/- ##
==========================================
- Coverage 59.13% 59.12% -0.02% 
==========================================
Files 355 356 +1 Lines 29744 29750 +6 ==========================================
Hits 17590 17590 - Misses 11179 11186 +7 + Partials 975 974 -1 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
thaJeztahforce-pushed the move_prompt_utils_step1 branch from afe1ab9 to 12c00f8CompareMarch 22, 2025 14:17
Comment threadcli/command/utils.go
@thaJeztah
thaJeztahforce-pushed the move_prompt_utils_step1 branch from 12c00f8 to d75384eCompareMarch 22, 2025 14:24
"github.com/docker/cli/cli"
"github.com/docker/cli/cli/command"
"github.com/docker/cli/cli/command/completion"
"github.com/docker/cli/internal/prompt"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, but that would probably not work currently? i.e., that fork was because of docker/buildx#2359 (comment), or was that part of it reverted?

My thinking of keeping it "internal" for now at least, was because there may still be some work to do to get a stable "API" for these. There's some functions that currently depend on command.Stream (or equivalent), and ideally they'd be more generic (I'm a bit on the fence on the Stream wrappers; they're useful, but perhaps we can do without so that we can pass a regular os.StdIn / os.StdErr etc).

@vvolandvvoland modified the milestones: 28.0.3, 28.0.4, 28.0.5Mar 25, 2025
@thaJeztah
thaJeztahforce-pushed the move_prompt_utils_step1 branch 2 times, most recently from 66ff9be to d9b0d1bCompareApril 4, 2025 19:46
@thaJeztah
thaJeztahforce-pushed the move_prompt_utils_step1 branch from d9b0d1b to 4330eb1CompareApril 10, 2025 07:39
@thaJeztahthaJeztah modified the milestones: 28.0.5, 28.1.0Apr 10, 2025
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the move_prompt_utils_step1 branch from 4330eb1 to aa74eb4CompareApril 11, 2025 10:18
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the move_prompt_utils_step1 branch from aa74eb4 to b74b7b3CompareApril 11, 2025 10:23
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Rebase was for conflict in the imports; CI is happy again, so bringing this one in

@thaJeztah
thaJeztah merged commit 6aa93d1 into docker:masterApr 11, 2025
@thaJeztah
thaJeztah deleted the move_prompt_utils_step1 branch April 11, 2025 14:11
@thaJeztahthaJeztah self-assigned this May 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@codecov-commenter@crazy-max@Benehiko@vvoland