Skip to content

Improve completion of service scale args - #5968

Merged
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion-service-scale
Mar 26, 2025
Merged

Improve completion of service scale args#5968
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion-service-scale

Conversation

@albers

@albersalbers commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

Without this PR:
docker service scale <TAB> completes service names, followed by a space. This tempts the user to enter a number, producing illegal syntax, e.g. docker service scale nginx 2.

With this PR:
docker service scale <TAB> completes service names with "=" appended and no trailing space. This guides the user to the correct argument syntax, e.g. docker service scale nginx=2.

The legacy completion worked like this.

Improve CLI completion of `docker service scale`.

Signed-off-by: albers <github@albersweb.de>
@codecov-commenter

codecov-commenter commented Mar 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (b8034c0) to head (ee275d5).

Additional details and impacted files
@@ Coverage Diff @@## master #5968 +/- ##
==========================================
- Coverage 59.09% 59.08% -0.02% 
==========================================
Files 354 354 Lines 29733 29741 +8 ==========================================
Hits 17572 17572 - Misses 11191 11199 +8 
Partials 970 970 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albers

Copy link
Copy Markdown
CollaboratorAuthor

@thaJeztah The test failures seem not to be related to my changes.

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@thaJeztah
thaJeztah merged commit f1385df into docker:masterMar 26, 2025
@albers
albers deleted the completion-service-scale branch March 26, 2025 20:17
@thaJeztahthaJeztah modified the milestones: 28.0.5, 28.1.0Apr 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@albers@codecov-commenter@thaJeztah@vvoland