Uh oh!
There was an error while loading. Please reload this page.
cli/command: move TestExperimentalCLI to cli/config - #5976
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #5976 +/- ##
=======================================
Coverage 59.12% 59.12% =======================================
Files 355 355 Lines 29740 29740 =======================================
Hits 17583 17583 Misses 11182 11182 Partials 975 975 🚀 New features to boost your workflow:
|
This test was only testing whether we could load a legacy config-file that contained the "experimental" (experimental CLI) option. Experimental cli options are disabled since 977d3ae (20.10), and now enabled by default, but we should not fail to start the cli if the config-file contains the option. Move the test to the config package, as it doesn't need the cli for this. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
cli_move_TestExperimentalCLI
branch
from
April 1, 2025 15:06
ab9c4ad to
0dabdd1Comparevvoland
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was only testing whether we could load a legacy config-file that contained the "experimental" (experimental CLI) option. Experimental cli options are disabled since 977d3ae (20.10), and now enabled by default, but we should not fail to start the cli if the config-file contains the option.
Move the test to the config package, as it doesn't need the cli for this.
- A picture of a cute animal (not mandatory but encouraged)