Skip to content

cli/config/configfile: deprecate ConfigFile.Experimental field - #5977

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:deprecate_config_experimental
Apr 10, 2025
Merged

cli/config/configfile: deprecate ConfigFile.Experimental field#5977
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:deprecate_config_experimental

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

relates to:

Configuration options for experimental CLI features were deprecated in docker 19.03 (3172219), and enabled by default since docker 20.10 (977d3ae).

This deprecates the corresponding field in the config-file.

- Human readable description for the release notes

Go SDK: cli/config/configfile: deprecate `ConfigFile.Experimental` field. Experimental CLI features are always enabled since version v20.10 and this field is no longer used. Use `ConfigFile.Features` instead for optional features. This field will be removed in a future release.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztahthaJeztah added impact/changelog impact/deprecation status/2-code-review area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Apr 1, 2025
@codecov-commenter

codecov-commenter commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (3349492) to head (c8f9187).

Additional details and impacted files
@@ Coverage Diff @@## master #5977 +/- ##
=======================================
Coverage 59.12% 59.12% =======================================
Files 355 355 Lines 29740 29740 =======================================
Hits 17583 17583 Misses 11182 11182 Partials 975 975 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Booh! I was afraid it would complain; I tried to keep the diff minimal, but I may have to break it up into multiple lines;

#15 68.00 cli/config/configfile/file.go:39: line-length-limit: line is 273 characters, out of limit 200 (revive)
#15 68.00 Experimental string `json:"experimental,omitempty"` // Deprecated: experimental CLI features are always enabled and this field is no longer used. Use [Features] instead for optional 

Configuration options for experimental CLI features were deprecated in
docker 19.03 (3172219), and enabled by
default since docker 20.10 (977d3ae).
This deprecates the corresponding field in the config-file.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the deprecate_config_experimental branch from 1eee1eb to c8f9187CompareApril 1, 2025 15:08
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@vvoland@Benehiko ptal 🤗

@thaJeztah
thaJeztah merged commit 23d7346 into docker:masterApr 10, 2025
@thaJeztah
thaJeztah deleted the deprecate_config_experimental branch April 10, 2025 12:36
@thaJeztahthaJeztah added this to the 28.1.0 milestone Apr 10, 2025
@thaJeztahthaJeztah self-assigned this May 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdkChanges affecting the Go SDKimpact/changelogimpact/deprecationimpact/go-sdkNoteworthy (compatibility changes) in the Go SDKstatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@Benehiko@vvoland