Skip to content

cli/command/formatter: fix .Labels format being randomized - #6073

Merged
thaJeztah merged 3 commits into
docker:masterfrom
thaJeztah:format_cleanups_and_fixes
May 16, 2025
Merged

cli/command/formatter: fix .Labels format being randomized#6073
thaJeztah merged 3 commits into
docker:masterfrom
thaJeztah:format_cleanups_and_fixes

Conversation

@thaJeztah

@thaJeztahthaJeztah commented May 16, 2025

Copy link
Copy Markdown
Member

see individual commits for details

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
no need to initialize with an empty string
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The labels are stored as a map, causing the output to be randomized.
This patch sorts the result to get a consistent output.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 28.2.0 milestone May 16, 2025
@codecov-commenter

codecov-commenter commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (cacd86c) to head (5ee17ee).

Additional details and impacted files
@@ Coverage Diff @@## master #6073 +/- ##
==========================================
- Coverage 55.10% 55.07% -0.04% 
==========================================
Files 359 359 Lines 30046 30063 +17 ==========================================
- Hits 16558 16557 -1 - Misses 12542 12555 +13 - Partials 946 951 +5 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
thaJeztah requested review from Benehiko and vvolandMay 16, 2025 12:31
@thaJeztah
thaJeztah merged commit 12992f7 into docker:masterMay 16, 2025
@thaJeztah
thaJeztah deleted the format_cleanups_and_fixes branch May 16, 2025 13:01
@thaJeztahthaJeztah self-assigned this May 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@Benehiko@vvoland