Skip to content

mount /var/run/docker.sock for --use-api-socket - #6157

Merged
thaJeztah merged 1 commit into
docker:masterfrom
ndeloof:use_api_socket
Jul 1, 2025
Merged

mount /var/run/docker.sock for --use-api-socket#6157
thaJeztah merged 1 commit into
docker:masterfrom
ndeloof:use_api_socket

Conversation

@ndeloof

@ndeloofndeloof commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

- What I did

s.dockerCli.DockerEndpoint().Host returns the engine URL as seen by client, which is only relevant an Unix/MacOS with a local docker engine. Waiting for engine to expose this information in some API, or implement this feature on its own, hard-coding /var/run/docker.sock offer a more reliable path for engine socket to be mounted in container, while not 100% guaranteed to succeed.

- How I did it

hard-coded path

- How to verify it

- Human readable description for the release notes

Fix `--use-api-socket` not working correctly when targeting a remote daemon.

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

codecov-commenter commented Jun 30, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (7cbee73) to head (2ba7cb8).

Additional details and impacted files
@@ Coverage Diff @@## master #6157 +/- ##
=======================================
Coverage 54.82% 54.83% =======================================
Files 364 364 Lines 30470 30467 -3 =======================================
Hits 16706 16706 + Misses 12789 12786 -3 
Partials 975 975 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndeloof
ndeloofforce-pushed the use_api_socket branch 3 times, most recently from 2bde860 to 163f4c6CompareJune 30, 2025 10:36
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ndeloof@codecov-commenter@thaJeztah@vvoland