Skip to content

cli/command: deprecate RegistryAuthenticationPrivilegedFunc - #6184

Merged
thaJeztah merged 1 commit into
docker:masterfrom
Benehiko:deprecate-prompt-privilege-func
Jul 16, 2025
Merged

cli/command: deprecate RegistryAuthenticationPrivilegedFunc#6184
thaJeztah merged 1 commit into
docker:masterfrom
Benehiko:deprecate-prompt-privilege-func

Conversation

@Benehiko

@BenehikoBenehiko commented Jul 16, 2025

Copy link
Copy Markdown
Member

This patch deprecates the unused RegistryAuthenticationPrivilegedFunc. The function would prompt the user when the registry returns a 403 after trying the initial auth value set in RegistryAuth.

Relates to:

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: deprecate `cli/command.RegistryAuthenticationPrivilegedFunc`

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Benehiko
Benehiko requested a review from thaJeztahJuly 16, 2025 07:09
@BenehikoBenehiko changed the title cli/command: remove usages of RegistryAuthenticationPrivilegedFunccli/command: deprecate RegistryAuthenticationPrivilegedFuncJul 16, 2025
@thaJeztahthaJeztah added impact/changelog area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Jul 16, 2025
@thaJeztahthaJeztah added this to the 29.0.0 milestone Jul 16, 2025

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This patch deprecates the unused `RegistryAuthenticationPrivilegedFunc`.
The function would prompt the user when the registry returns a 403 after trying
the initial auth value set in `RegistryAuth`.
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@thaJeztah
thaJeztahforce-pushed the deprecate-prompt-privilege-func branch from d28f534 to 29263e8CompareJuly 16, 2025 10:49
@thaJeztah

Copy link
Copy Markdown
Member

Did a quick rebase after #6174 was merged; CI should go green now

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/authenticationarea/go-sdkChanges affecting the Go SDKimpact/changelogimpact/deprecationimpact/go-sdkNoteworthy (compatibility changes) in the Go SDKprocess/cherry-picked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Benehiko@codecov-commenter@thaJeztah@vvoland