Uh oh!
There was an error while loading. Please reload this page.
vendor: github.com/docker/go-connections v0.6.0 - #6250
Merged
Conversation
thaJeztahforce-pushed
the
bump_go_connections
branch
from
August 8, 2025 20:51
8f85bbf to
5eb0afdComparecodecov-commenter
commented
Aug 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
commented
Aug 8, 2025
Comment on lines
-174
to
+179
| proto, containerPort = SplitProtoPort(containerPort) | ||
| proto, containerPort := SplitProtoPort(containerPort) | ||
| proto = strings.ToLower(proto) | ||
| if err := validateProto(proto); err != nil { | ||
| return nil, err | ||
| } |
MemberAuthor
There was a problem hiding this comment.
Ah! Small change in behavior in docker/go-connections#121, because we validate protocol fist now, before port, so the error became a bit weird;
#18 67.27 === FAIL: opts/swarmopts TestPortOptInvalidSimpleSyntax (0.00s)
#18 67.27 port_test.go:321: assertion failed: expected error "no port specified: <empty>", got "invalid proto: "
Input ia an empty string;
cli/opts/swarmopts/port_test.go
Lines 310 to 313 in d16defd
thaJeztahforce-pushed
the
bump_go_connections
branch
from
August 11, 2025 12:28
5eb0afd to
9f2fd27Compare- deprecate sockets.GetProxyEnv, sockets.DialerFromEnvironment - add support for unix sockets on Windows - remove legacy CBC cipher suites from client config - align client and server defaults to be the same. - remove support for encrypted TLS private keys. - nat: optimize ParsePortSpec full diff: docker/go-connections@v0.5.0...v0.6.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
bump_go_connections
branch
from
August 11, 2025 13:33
9f2fd27 to
3529651CompareBenehiko
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: docker/go-connections@v0.5.0...v0.6.0
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)