Skip to content

cli/command/stack: move GetStacks and StackWrite internal - #6406

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:rm_GetStacks_StackWrite
Sep 1, 2025
Merged

cli/command/stack: move GetStacks and StackWrite internal#6406
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:rm_GetStacks_StackWrite

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Sep 1, 2025

Copy link
Copy Markdown
Member

These were deprecated in 036d3a6 and 30774ed, and were originally in the cli/command/stack package, but moved for the (now deprecated) Compose on Kubernetes feature in 4d947de.

- Human readable description for the release notes

Go SDK: remove deprecated cli/command/formatter package.
Go SDK: cli/command/formatter/swarm: remove deprecated `GetStacks` function.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
cli/command/stack: move GetStacks and StackWrite internal
6647e22
These were deprecated in 036d3a6 and
30774ed, and were originally in the
cli/command/stack package, but moved for the (now deprecated) Compose
on Kubernetes feature in 4d947de.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 29.0.0 milestone Sep 1, 2025
@thaJeztah
thaJeztah requested review from a team and silvin-lubecki as code ownersSeptember 1, 2025 07:44
@thaJeztahthaJeztah added impact/deprecation status/2-code-review area/stack kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Sep 1, 2025
@codecov-commenter

codecov-commenter commented Sep 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
cli/command/stack/list_formatter.go90.47%2 Missing ⚠️
cli/command/stack/cmd.go0.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah
thaJeztah merged commit 88f6827 into docker:masterSep 1, 2025
123 of 124 checks passed
@thaJeztah
thaJeztah deleted the rm_GetStacks_StackWrite branch September 1, 2025 11:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenehikoBenehikoBenehiko approved these changes
@silvin-lubeckisilvin-lubeckiAwaiting requested review from silvin-lubeckisilvin-lubecki is a code owner

Assignees

No one assigned

Labels

area/go-sdkChanges affecting the Go SDKarea/stackimpact/deprecationimpact/go-sdkNoteworthy (compatibility changes) in the Go SDKkind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@codecov-commenter@Benehiko