Skip to content

Move notary to its new location - #652

Merged
cpuguy83 merged 1 commit into
docker:masterfrom
thaJeztah:move-notary
Oct 30, 2017
Merged

Move notary to its new location#652
cpuguy83 merged 1 commit into
docker:masterfrom
thaJeztah:move-notary

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Oct 30, 2017

Copy link
Copy Markdown
Member

Comment threadvendor.conf Outdated
github.com/spf13/cobra 7b2c5ac9fc04fc5efafb60700713d4fa609b777b
github.com/spf13/pflag 97afa5e7ca8a08a383cb259e06636b5e2cc7897f
github.com/stretchr/testify 4d4bfba8f1d1027c4fdbe371823030df51419987
github.com/theupdateframework/notary 8a1de3cfc3f1408e54d6364fc949214a4883a9f3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated to 05985dc5d1c71ee6c387e9cd276a00b9d424af53 (the commit that moves the import paths) or later cc @endophage

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Forgot about references inside notary itself 🤦‍♂️

The https://github.com/docker/notary repository has moved to
https://github.com/theupdateframework/notary
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

codecov-io commented Oct 30, 2017

Copy link
Copy Markdown

Codecov Report

Merging #652 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #652 +/- ##
=======================================
Coverage 50.02% 50.02% =======================================
Files 216 216 Lines 17676 17676 =======================================
Hits 8842 8842 Misses 8391 8391 Partials 443 443

@dnephindnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riyazdfriyazdf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thaJeztah!

@cpuguy83cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
cpuguy83 merged commit 7ca234f into docker:masterOct 30, 2017
@GordonTheTurtleGordonTheTurtle added this to the 17.11.0 milestone Oct 30, 2017
@thaJeztah
thaJeztah deleted the move-notary branch October 30, 2017 18:07
@endophage

Copy link
Copy Markdown

@thaJeztah thanks for doing this before I got to it!

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

You're welcome! 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notary repo moving

7 participants

@thaJeztah@codecov-io@endophage@dnephin@cpuguy83@riyazdf@GordonTheTurtle