Skip to content

cli/config/types: make AuthConfig an alias for registry.AuthConfig - #6693

Draft
thaJeztah wants to merge 1 commit into
docker:masterfrom
thaJeztah:alias_authconfig
Draft

cli/config/types: make AuthConfig an alias for registry.AuthConfig#6693
thaJeztah wants to merge 1 commit into
docker:masterfrom
thaJeztah:alias_authconfig

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Dec 4, 2025

Copy link
Copy Markdown
Member

The AuthConfig type was forked from the docker/docker API types in commit 27b2797 to reduce the dependency on the docker API types in BuildKit and Buildx (see buildkit#800). Now that the API is a separate module with minimal dependencies, this should no longer be a big concern, so this patch un-forks the type.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

The AuthConfig type was forked from the docker/docker API types in commit
27b2797 to reduce the dependency on the
docker API types in BuildKit and Buildx (see [buildkit#800]). Now that
the API is a separate module with minimal dependencies, this should no longer
be a big concern, so this patch un-forks the type.
[buildkit#800]: moby/buildkit#800
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 12 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
cli/command/registry.go35.71%9 Missing ⚠️
cli/config/memorystore/store.go71.42%2 Missing ⚠️
cli/command/container/auth_config_utils.go0.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/authenticationkind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah@codecov-commenter