Uh oh!
There was an error while loading. Please reload this page.
Import man pages#68
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| .DS_Store | ||
| build | ||
| /man/man1 | ||
| /man/man5 | ||
| /man/man8 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -11,12 +11,13 @@ build: clean | ||
| .PHONY: clean | ||
| clean: | ||
| @rm -rf ./build/* | ||
| @rm -rf ./man/man[1-9] | ||
| # run go test | ||
| # the "-tags daemon" part is temporary | ||
| .PHONY: test | ||
| test: | ||
| @go test -tags daemon -v $(shell go list ./... | grep -vE '/vendor/|github.com/docker/cli/man$$') | ||
| # run linters | ||
| .PHONY: lint | ||
| @@ -32,10 +33,15 @@ cross: clean | ||
| .PHONY: vendor | ||
| vendor: vendor.conf | ||
| @vndr 2> /dev/null | ||
| @scripts/validate/check-git-diff vendor | ||
| ## Generate man pages from go source and markdown | ||
| .PHONY: manpages | ||
| manpages: | ||
| @man/generate.sh | ||
Contributor There was a problem hiding this comment. This doesn't need to be I believe something like this would be correct: Contributor There was a problem hiding this comment. Can you use wildcards in But be careful: this: Does not cause Contributor There was a problem hiding this comment. I guess this would be easier to do if we wrote the man pages to Contributor There was a problem hiding this comment. Not entirely sure how Contributor There was a problem hiding this comment. Yes, I think that's how it works. I did it for | ||
| cli/compose/schema/bindata.go: cli/compose/schema/data/*.json | ||
| go generate github.com/docker/cli/cli/compose/schema | ||
| compose-jsonschema: cli/compose/schema/bindata.go | ||
| @scripts/validate/check-git-diff cli/compose/schema/bindata.go | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it necessary to exclude the man directory from testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of missing packages, that are included only after the vendor-on-the-fly part of generate.sh