Uh oh!
There was an error while loading. Please reload this page.
cli/compose: accept numeric cpus in stack deploy schema - #7230
Open
locker95 wants to merge 1 commit into
Open
Conversation
compose config emits deploy.resources.cpus as a number. The v3 schema only allowed strings, so piping one into docker stack deploy failed with "cpus must be a string". Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker compose configwritesdeploy.resources.*.cpusas a number.docker stack deploystill uses the v3 schema, which only allowed a string, so piping one into the other dies withcpus must be a string.Allow number or string in the schema, and stringify numbers on load so the existing NanoCPUs parser still works.
Fixes#5009