Skip to content

Add support for generic resources to bash completion - #749

Merged
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion--generic-resource
Dec 15, 2017
Merged

Add support for generic resources to bash completion#749
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion--generic-resource

Conversation

@albers

Copy link
Copy Markdown
Collaborator

Adds bash completion for #429:

  • service create --generic-resource
  • service update --generic-resource-(add|rm)
  • dockerd --node-generic-resource

@codecov-io

codecov-io commented Dec 13, 2017

Copy link
Copy Markdown

Codecov Report

Merging #749 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #749 +/- ##
=======================================
Coverage 53.45% 53.45% =======================================
Files 218 218 Lines 14613 14613 =======================================
Hits 7811 7811 Misses 6321 6321 Partials 481 481

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, but LGTM otherwise

--dns-search-rm
--group-add
--group-rm
--generic-resource-add

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to keep this alphabetical? If so, it should be above the --group-... lines 🤗

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alphabet is really comlicated...
Thanks for catching. PR is updated.

Adds bash completion for
- `service create --generic-resource`
- `service update --generic-resource-(add|rm)`
- `dockerd --node-generic-resource`
Signed-off-by: Harald Albers <github@albersweb.de>
@albers
albersforce-pushed the completion--generic-resource branch from 3373a60 to 8ec80eeCompareDecember 15, 2017 07:56

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@thaJeztah

Copy link
Copy Markdown
Member

😄 thanks!

merging, so that I can cherry-pick

@thaJeztah
thaJeztah merged commit 8684b99 into docker:masterDec 15, 2017
@GordonTheTurtleGordonTheTurtle added this to the 18.01.0 milestone Dec 15, 2017
@albers
albers deleted the completion--generic-resource branch December 15, 2017 12:57
@thaJeztahthaJeztah modified the milestones: 18.01.0, 17.12.0Dec 16, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Add support for generic resources to bash completion
Upstream-commit: 8684b99
Component: cli
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@albers@codecov-io@thaJeztah@vdemeester@GordonTheTurtle