Uh oh!
There was an error while loading. Please reload this page.
Allow user to specify default address pools for docker networks - #818
Merged
Conversation
selansen
requested review from
mdlinville, thaJeztah and vdemeester
as code ownersJanuary 19, 2018 01:04
Codecov Report
@@ Coverage Diff @@## master #818 +/- ##
=========================================
Coverage ? 51.67% =========================================
Files ? 244 Lines ? 15823 Branches ? 0 =========================================
Hits ? 8177 Misses ? 7101 Partials ? 545 |
thaJeztah
requested changes
May 1, 2018
| -D, --debug Enable debug mode | ||
| --default-gateway ip Container default gateway IPv4 address | ||
| --default-gateway-v6 ip Container default gateway IPv6 address | ||
| --default-address-pools Set the default address pools for local node networks |
Member
There was a problem hiding this comment.
This should be singular now
Also, I think this page has an example daemon.json; can you update that one as well (with some example values)
| [**-D**|**--debug**] | ||
| [**--default-gateway**[=*DEFAULT-GATEWAY*]] | ||
| [**--default-gateway-v6**[=*DEFAULT-GATEWAY-V6*]] | ||
| [**--default-address-pools**[=*DEFAULT-ADDRESS-POOLS*]] |
selansen
commented
May 1, 2018
via email
ContributorAuthor
will correct it …On Tue, May 1, 2018 at 8:17 AM, Sebastiaan van Stijn < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In docs/reference/commandline/dockerd.md
<#818 (comment)>:
> @@ -40,6 +40,7 @@ Options:
-D, --debug Enable debug mode
--default-gateway ip Container default gateway IPv4 address
--default-gateway-v6 ip Container default gateway IPv6 address
+ --default-address-pools Set the default address pools for local node networks
This should be singular now
Also, I think this page has an example daemon.json; can you update that
one as well (with some example values)
------------------------------
In man/dockerd.8.md
<#818 (comment)>:
> @@ -22,6 +22,7 @@ dockerd - Enable daemon mode
[**-D**|**--debug**]
[**--default-gateway**[=*DEFAULT-GATEWAY*]]
[**--default-gateway-v6**[=*DEFAULT-GATEWAY-V6*]]
+[**--default-address-pools**[=*DEFAULT-ADDRESS-POOLS*]]
same here
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#818 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKEKnxQIURxbluZ8L6fo7PtP20KLVw4aks5tuFJhgaJpZM4Rj1ue>
.
|
selansenforce-pushed
the
master
branch
2 times, most recently
from
May 4, 2018 17:21
43c360e to
e949b50Compareselansen
commented
May 4, 2018
ContributorAuthor
I thought I pushed my changes but looks like I forgot to push it. updated @thaJeztah review comments. |
| ] | ||
| } | ||
| } | ||
| "default-address-pools":[{"base":"172.80.0.0/16","size":24}, |
Member
There was a problem hiding this comment.
Looks like there's a comma missing in the JSON (it shows as invalid)
This is separate commit for CLI files to address PR 36054 Signed-off-by: selansen <elango.siva@docker.com>
selansen
commented
May 5, 2018
ContributorAuthor
corrected it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is separate commit for CLI files to address PR
moby/moby#36054moby/moby#36396Signed-off-by: selansen elango.siva@docker.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)