Run tests using Docker-in-Docker so we can test multiple versions

[aanand]

This build will fail on Wercker because it depends on docker build -f FILE, which isn't available in Wercker's Docker version (1.2.0).

Next step: get running on Jenkins!

[jessfraz]

👍

[jessfraz]

I would add a tag to each of these that is the commit sha so docker-compose:$(git rev-parse --short HEAD)

[jessfraz]

otherwise for parallel builds things are going to get tricky

[jessfraz]

ping @tianon bash god, this going to be tested on jenkins

[jessfraz]

Can we also keep in mind I'm not just going to put "script/test" into Jenkins I'm going to put the docker commands because who is to say someone won't change this into something that we don't want to execute so can we try to keep it concise :)

[jessfraz]

We can also set this up next week when I am in your neck of the woods \o/

[aanand]

OK, I've set it up so that you can kick the whole thing off with a single docker run. This requires two levels of Docker nesting (an outer one where we mount docker.sock, an inner one where we run Docker-in-Docker), but it works.

You should be able to just run:

TAG="docker-compose:$(git rev-parse --short HEAD)"
docker build -t "$TAG".
docker run \
--rm \
--volume="/var/run/docker.sock:/var/run/docker.sock" \
-e "DOCKER_VERSIONS=all" \
-e "TAG=$TAG" \
--entrypoint="script/test-versions" \
"$TAG" \
--verbose

[jessfraz]

You rule!!!!

On Thursday, February 26, 2015, Aanand Prasad notifications@github.com
wrote:

OK, I've set it up so that you can kick the whole thing off with a single docker
run. This requires two levels of Docker nesting (an outer one where we
mount docker.sock, an inner one where we run Docker-in-Docker), but it
works.

You should be able to just run:

TAG="docker-compose:$(git rev-parse --short HEAD)"

docker build -t "$TAG" .

docker run
--rm
--volume="/var/run/docker.sock:/var/run/docker.sock"
-e "DOCKER_VERSIONS=all"
-e "TAG=$TAG"
--entrypoint="script/test-versions"
"$TAG"
--verbose

—
Reply to this email directly or view it on GitHub
#1005 (comment).

[jessfraz]

I think its hanging https://jenkins.dockerproject.com/job/Compose%20Master/7/label=ubuntu-aufs-prs/console :( I dont understand

[bfirsh]

This needs to be run on the same line as apt-get install otherwise it'll actually make the image bigger. (The debs are still in the layers before then this adds another layer that needs downloading.)

[tianon]

It also won't actually do anything: https://github.com/docker/docker/blob/738bdec4908755761b27b7d15baeefb1a824f770/contrib/mkimage/debootstrap#L72-L95

The pattern we usually use is RUN apt-get update && apt-get install -y ... && rm -rf /var/lib/apt/lists/*.

[tianon]

Looks sane to me 👍

[jessfraz]

LGTM https://jenkins.dockerproject.com/job/Compose%20Master/label=ubuntu-aufs-prs/8/console merge it and i will turn all on

[dnephin]

Nice! It would be awesome to have this run against multiple python versions as well. Even if it's only python2.6+latest docker, python2.7+latest docker.

At some point we'll want to add python3.4+latest docker

[jessfraz]

merge it merge it merge it

[bfirsh]

Hells yeah

[bfirsh]

ping @jfrazelle

[bfirsh]

When we get the 1.6 RC, I wonder if we can test against that too...

[jessfraz]

You would just add t to the Dockerfile from the looks of it

[bfirsh]

Oh, yeah. Assumed that'd be in Jenkins. Nice.

[aanand]

Reactivated webhooks, rebased #1088, all looks good.

[aanand]

We're not validating the DCO any more - that's very bad. Where's the best place to do that? Presumably not inside a docker run - we don't put .git inside the Docker image.

[aanand]

We could mount the code directory as a volume, and then I can add a script/validate-dco line to the top of script/test-versions. @jfrazelle: sound sensible?

[jessfraz]

ya totally sgtm

On Tue, Mar 17, 2015 at 4:59 PM, Aanand Prasad notifications@github.com
wrote:

We could mount the code directory as a volume, and then I can add a
script/validate-dco line to the top of script/test-versions. @jfrazelle
https://github.com/jfrazelle: sound sensible?

—
Reply to this email directly or view it on GitHub
#1005 (comment).

[aanand]

@jfrazelle Cool - see #1128.