Skip to content

build and push binaries images when a PR is merged or a tag pushed - #10371

Merged
ndeloof merged 1 commit into
docker:v2from
glours:binary-image
Mar 16, 2023
Merged

build and push binaries images when a PR is merged or a tag pushed#10371
ndeloof merged 1 commit into
docker:v2from
glours:binary-image

Conversation

@glours

@gloursglours commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

What I did
Generate new binary images when a PR is merged into main branch or a tag is pushed, those images would be pushed to docker/compose Hub repo

Related issue
https://docker.atlassian.net/browse/ENV-119

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@gloursglours self-assigned this Mar 14, 2023
@glours
glours requested review from a team, StefanScherer, crazy-max, laurazard, milas, ndeloof, nicksieger and ulyssessouza and removed request for a teamMarch 14, 2023 10:11
crazy-max
crazy-max reviewed Mar 14, 2023
View reviewed changes
Comment thread.github/workflows/merge.yml Outdated
Comment thread.github/workflows/merge.yml Outdated
Comment thread.github/workflows/merge.yml Outdated
Comment thread.github/workflows/merge.yml Outdated
@glours
gloursforce-pushed the binary-image branch 2 times, most recently from 1c10a34 to 5e49490CompareMarch 14, 2023 10:59
thaJeztah
thaJeztah reviewed Mar 14, 2023
View reviewed changes
Comment thread.github/workflows/merge.yml Outdated
@codecov

codecovBot commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (e0aaccf) 53.37% compared to head (af22c91) 53.46%.

Additional details and impacted files
@@ Coverage Diff @@## v2 #10371 +/- ##
==========================================
+ Coverage 53.37% 53.46% +0.08% 
==========================================
Files 104 104 Lines 8927 8927 ==========================================
+ Hits 4765 4773 +8 + Misses 3642 3636 -6 + Partials 520 518 -2

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours
build and push binaries images when a PR is merged or a tag pushed
af22c91
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
crazy-max
crazy-max approved these changes Mar 15, 2023
View reviewed changes

@crazy-maxcrazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

StefanScherer
StefanScherer approved these changes Mar 15, 2023
View reviewed changes

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof
ndeloof merged commit 643557d into docker:v2Mar 16, 2023
@glours
glours deleted the binary-image branch June 30, 2025 21:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztahthaJeztahthaJeztah left review comments
@ndeloofndeloofndeloof approved these changes
@crazy-maxcrazy-maxcrazy-max approved these changes
@nicksiegernicksiegerAwaiting requested review from nicksiegernicksieger was automatically assigned from docker/compose-maintainers
@ulyssessouzaulyssessouzaAwaiting requested review from ulyssessouzaulyssessouza was automatically assigned from docker/compose-maintainers
@milasmilasAwaiting requested review from milasmilas was automatically assigned from docker/compose-maintainers
@laurazardlaurazardAwaiting requested review from laurazardlaurazard was automatically assigned from docker/compose-maintainers
+1 more reviewer
@StefanSchererStefanSchererStefanScherer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gloursglours

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@glours@ndeloof@StefanScherer@thaJeztah@crazy-max