Uh oh!
There was an error while loading. Please reload this page.
Remove restriction for requests version, update docker-py requirement - #1100
Merged
Conversation
Closed
There was a problem hiding this comment.
To be safe I would do < 3.
Major versions can easily break compatibility.
vmalloc
commented
Mar 13, 2015
Author
Updated according to comments. |
aanand
commented
Mar 13, 2015
Thanks! I feel a bit nervous about those version ranges, and would rather pin to minor versions: 'requests >= 2.5.0, < 2.6',
...
'docker-py >= 1.1.0, < 1.2',Furthermore, |
vmalloc
commented
Mar 13, 2015
Author
Updated accordingly. |
KyleJamesWalker
commented
Mar 13, 2015
Note: PR #1075 also has these changes. |
dnephin
commented
Mar 13, 2015
LGTM |
1 similar comment
aanand
commented
Mar 13, 2015
LGTM |
aanand added a commit
that referenced
this pull request
Mar 13, 2015
Remove restriction for requests version, update docker-py requirement
yuval-k pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Remove restriction for requests version, update docker-py requirement Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.