Skip to content

Enhance JSON progress events with more fields. - #12000

Merged
ndeloof merged 1 commit into
docker:mainfrom
cmrigney:enhance-json-progress
Jul 23, 2024
Merged

Enhance JSON progress events with more fields.#12000
ndeloof merged 1 commit into
docker:mainfrom
cmrigney:enhance-json-progress

Conversation

@cmrigney

@cmrigneycmrigney commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

What I did
I added the rest of the event fields to json progress events. Namely ParentID, Current, Total, and Percent.

Related issue

closes#11999

Signed-off-by: Cody Rigney <cody.rigney@docker.com>
@cmrigney
cmrigneyforce-pushed the enhance-json-progress branch from d383ce5 to 8a0dc40CompareJuly 22, 2024 18:01
@glours
glours requested review from a team, glours, jhrotko and ndeloof and removed request for a teamJuly 23, 2024 08:43

@gloursglours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof
ndeloof merged commit 44337d2 into docker:mainJul 23, 2024
@cmrigney
cmrigney deleted the enhance-json-progress branch July 23, 2024 14:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON progress writer is missing some event fields

3 participants

@cmrigney@glours@ndeloof