Skip to content

do not throw an error on build with provider services - #12842

Merged
ndeloof merged 1 commit into
docker:mainfrom
glours:fix-build-provider-error
May 16, 2025
Merged

do not throw an error on build with provider services#12842
ndeloof merged 1 commit into
docker:mainfrom
glours:fix-build-provider-error

Conversation

@glours

Copy link
Copy Markdown
Contributor

What I did
Avoid to throw an error on build command for provider service as they don't have neither image or build attributes

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours
glours requested a review from a team as a code ownerMay 16, 2025 15:37
@glours
glours requested a review from ndeloofMay 16, 2025 15:37
@gloursglours self-assigned this May 16, 2025
@ndeloof
ndeloof enabled auto-merge (rebase) May 16, 2025 15:47
@ndeloof
ndeloof merged commit 944e5e6 into docker:mainMay 16, 2025
@codecov

codecovBot commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.51%. Comparing base (01e83de) to head (cf26cb7).
Report is 61 commits behind head on main.

Files with missing linesPatch %Lines
pkg/api/api.go0.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #12842 +/- ##
==========================================
+ Coverage 51.78% 53.51% +1.73% 
==========================================
Files 158 158 Lines 16533 16213 -320 ==========================================
+ Hits 8562 8677 +115 + Misses 7096 6657 -439 - Partials 875 879 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 20, 2025
This MR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.36.0` -> `v2.36.1` |
MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).
**Proposed changes to behavior should be submitted there as MRs.**
---
### Release Notes
<details>
<summary>docker/compose (docker/compose)</summary>
### [`v2.36.1`](https://github.com/docker/compose/releases/tag/v2.36.1)
[Compare Source](docker/compose@v2.36.0...v2.36.1)
#### What's Changed
##### ✨ Improvements
- Provider.options can be an array by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12819
- Set provider environment by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12817
- Add support of `debug` messages in the communication between Compose … by [@&#8203;glours](https://github.com/glours) in docker/compose#12826
- Introduce config `--lock-image-digests` by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12843
##### 🐛 Fixes
- Skip push step for provider services by [@&#8203;glours](https://github.com/glours) in docker/compose#12818
- Provider info by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12820
- Append `.exe` to provider name doing executable lookup on windows by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12832
- Fix quiet option when using COMPOSE_BAKE=1 by [@&#8203;AnvarU](https://github.com/AnvarU) in docker/compose#12838
- Do not throw an error on build with provider services by [@&#8203;glours](https://github.com/glours) in docker/compose#12842
- Report cancelled pull after another one failed by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12840
- Ensure build dependencies are enabled by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12824
##### 🔧 Internal
- Simplification by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12811
- Remove Docker EULA licensing which isn't relevant by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12829
- Remove convert alias from config command by [@&#8203;glours](https://github.com/glours) in docker/compose#12850
##### ⚙️ Dependencies
- Build(deps): bump github.com/containerd/containerd/v2 from 2.0.5 to 2.1.0 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#12813
- Build(deps): bump google.golang.org/grpc from 1.72.0 to 1.72.1 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#12837
- Bump compose-go to v2.6.3 by [@&#8203;glours](https://github.com/glours) in docker/compose#12849
**Full Changelog**: docker/compose@v2.36.0...v2.36.1
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNS4wIiwidXBkYXRlZEluVmVyIjoiNDAuMTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
@glours
glours deleted the fix-build-provider-error branch June 30, 2025 21:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@glours@ndeloof