Uh oh!
There was an error while loading. Please reload this page.
fix (regression): compose build render build output with tty support - #13107
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Hm... interesting; I saw this PR and recalled I stumbled on something similar. While it's for funcPromptUserForCredentials(ctx context.Context, cliCli, argUser, argPassword, defaultUsername, serverAddressstring) (registrytypes.AuthConfig, error) {
// On Windows, force the use of the regular OS stdin stream.//// See:// - https://github.com/moby/moby/issues/14336// - https://github.com/moby/moby/issues/14210// - https://github.com/moby/moby/pull/17738//// TODO(thaJeztah): we need to confirm if this special handling is still needed, as we may not be doing this in other places.ifruntime.GOOS=="windows" {
cli.SetIn(streams.NewIn(os.Stdin))
}Similar code in another place; https://github.com/docker/cli/blob/a1035b0796241b3bbd0f41940525373001fc146c/internal/prompt/prompt.go#L90-L93 Definitely looks like something to look into. The |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.39.1` -> `v2.39.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.39.2`](https://github.com/docker/compose/releases/tag/v2.39.2) [Compare Source](docker/compose@v2.39.1...v2.39.2) #### What's Changed ##### 🐛 Fixes - Fix (regression): compose build render build output with tty support by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13107 - Add missing `_MODEL` suffix to model variable pass to dependent services of a model by [@​glours](https://github.com/glours) in docker/compose#13109 - Apply `BUILDKIT_PROGRESS` value when building with bake by [@​glours](https://github.com/glours) in docker/compose#13110 - Define `pull` and `no_cache` from either service or flags values when building with bake by [@​glours](https://github.com/glours) in docker/compose#13133 - Only monitor attached services on `up` command by [@​glours](https://github.com/glours) in docker/compose#13114 ##### 🔧 Internal - Add Streams Comment by [@​suwakei](https://github.com/suwakei) in docker/compose#13103 - Add test of `json.go` by [@​suwakei](https://github.com/suwakei) in docker/compose#13106 - Refactoring of redundant condition checks by [@​suwakei](https://github.com/suwakei) in docker/compose#13104 - Eliminated magic string by [@​suwakei](https://github.com/suwakei) in docker/compose#13105 - Use log API for containers we didn't attached to by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13111 - Use `cli-plugins/metadata` package by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#13130 - `pkg/compose`: simplify getting auth-config key by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#13120 - Add go as a prerequisite in build instructions by [@​mattrunyon](https://github.com/mattrunyon) in docker/compose#13131 ##### ⚙️ Dependencies - Build(deps): bump github.com/docker/cli from `28.3.2+incompatible` to `28.3.3+incompatible` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13116 - Build(deps): bump github.com/docker/docker from `28.3.2+incompatible` to `28.3.3+incompatible` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13115 - Build(deps): bump github.com/containerd/containerd/v2 from `2.1.3` to `2.1.4` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13119 - Build(deps): bump github.com/docker/go-connections from `0.5.0` to `0.6.0` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13137 - Build(deps): bump golang.org/x/sys from `0.34.0` to `0.35.0` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13138 - Bump golang to `1.23.12` by [@​austinvazquez](https://github.com/austinvazquez) in docker/compose#13142 #### New Contributors - [@​mattrunyon](https://github.com/mattrunyon) made their first contribution in docker/compose#13131 - [@​austinvazquez](https://github.com/austinvazquez) made their first contribution in docker/compose#13142 **Full Changelog**: docker/compose@v2.39.1...v2.39.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41OC4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
What I did
buildkit (actually, containerd/console) requires a
*Fileto access the raw terminal and render build progress UIit actually can't just be based on a file descriptor (we can get for
dockerCli.Out().FD()) as windows support requires an actual file 🥲so .. we have to assume dockerCli.Out == os.Stdout, which basically makes dockerCli.Out abstraction useless 🥹
Related issue
fixes#13099
(not mandatory) A picture of a cute animal, if possible in relation to what you did