Skip to content

gha: update test-matrix: remove docker 26.x - #13254

Merged
glours merged 1 commit into
docker:mainfrom
thaJeztah:update_test_matrix
Sep 29, 2025
Merged

gha: update test-matrix: remove docker 26.x#13254
glours merged 1 commit into
docker:mainfrom
thaJeztah:update_test_matrix

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Sep 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

gha: update test-matrix: remove docker 26.x

  • Mirantis Container Runtime (MCR) 23.0 reached EOL, and the next LTS
    version of MCR is 25.x, but download.docker.com does not have 25.x
    packages for the latest Ubuntu release.
  • Docker 26.x reached EOL and is no longer maintained

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@thaJeztah

thaJeztah commented Sep 29, 2025

Copy link
Copy Markdown
MemberAuthor

Ah! I thought something like this would be the case; download.docker.com doesn't have 25.x packages for Ubuntu Noble, so installation fails.

# Executing docker install script, commit: 1ebc10ccd106153669a1e7b5984497e0fcf9d3b1
+ sh -c apt-get -qq update >/dev/null
+ sh -c DEBIAN_FRONTEND=noninteractive apt-get -y -qq install ca-certificates curl >/dev/null
+ sh -c install -m 0755 -d /etc/apt/keyrings
+ sh -c curl -fsSL "https://download.docker.com/linux/ubuntu/gpg" -o /etc/apt/keyrings/docker.asc
+ sh -c chmod a+r /etc/apt/keyrings/docker.asc
+ sh -c echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu noble test" > /etc/apt/sources.list.d/docker.list
+ sh -c apt-get -qq update >/dev/null
INFO: Searching repository for VERSION '25'
INFO: apt-cache madison docker-ce | grep '25' | head -1 | awk '{$1=$1};1' | cut -d' ' -f 3
ERROR: '25' not found amongst apt-cache madison results

Guess we should just remove 26.x, and not add 25.x

@thaJeztahthaJeztah changed the title gha: update test-matrix: remove docker 26.x, add 25.xgha: update test-matrix: remove docker 26.xSep 29, 2025
@thaJeztah
gha: update test-matrix: remove docker 26.x
e54da7e
- Mirantis Container Runtime (MCR) 23.0 reached EOL, and the next LTS
version of MCR is 25.x, but download.docker.com does not have 25.x
packages for the latest Ubuntu release.
- Docker 26.x reached EOL and is no longer maintained
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

thaJeztah commented Sep 29, 2025

Copy link
Copy Markdown
MemberAuthor

Ah, this requires changes to the repository config, as the 26 check is marked as "required", so GitHub actions will wait for that check to complete (which it won't)

@thaJeztah
thaJeztah marked this pull request as ready for review September 29, 2025 12:16
@thaJeztah
thaJeztah requested a review from a team as a code ownerSeptember 29, 2025 12:16
@thaJeztah

thaJeztah commented Sep 29, 2025

Copy link
Copy Markdown
MemberAuthor

Ah, this requires changes to the repository config, as the 26 check is marked as "required", so GitHub actions will wait for that check to complete (which it won't)

I don't have permissions to change those rules, but perhaps @ndeloof or @glours can update the settings if this PR looks good otherwise 😅

glours
glours approved these changes Sep 29, 2025
View reviewed changes

@gloursglours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours

glours commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

@thaJeztah settings updated 😉

@glours
glours enabled auto-merge (rebase) September 29, 2025 12:19
@thaJeztah

thaJeztah commented Sep 29, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks!

@glours
glours merged commit 9ded168 into docker:mainSep 29, 2025
23 checks passed
@thaJeztah
thaJeztah deleted the update_test_matrix branch September 29, 2025 13:11
@rancherbotrancherbot mentioned this pull request Oct 3, 2025
Merged
@BrewTestBotBrewTestBot mentioned this pull request Oct 6, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 10, 2025
ECG Bot@tmeijn
build(deps): update docker/compose to v2.40.0
56d5e69
This MR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | minor | `v2.39.4` -> `v2.40.0` |
MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).
**Proposed changes to behavior should be submitted there as MRs.**
---
### Release Notes
<details>
<summary>docker/compose (docker/compose)</summary>
### [`v2.40.0`](https://github.com/docker/compose/releases/tag/v2.40.0)
[Compare Source](docker/compose@v2.39.4...v2.40.0)
#### What's Changed
##### ✨ Improvements
- publish Compose application as compose.yaml + images by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13257](docker/compose#13257)
##### 🐛 Fixes
- resolve secrets based on env var before executing bake by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13237](docker/compose#13237)
- pass bake secrets by env by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13249](docker/compose#13249)
- escape $ in bake.json as interpolation already has been managed by cpmpose by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13259](docker/compose#13259)
##### 🔧 Internal
- pkg/compose: remove uses of deprecated mitchellh/mapstructure module by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13239](docker/compose#13239)
- pkg/watch: remove unused IsWindowsShortReadError by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13052](docker/compose#13052)
- pkg/compose: build: remove permissions warning on Windows by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13236](docker/compose#13236)
- pluginMain: remove uses of DockerCLI.Apply by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13240](docker/compose#13240)
- use containerd registry client by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13245](docker/compose#13245)
- provider services: use '--project-name=' notation by [@&#8203;glours](https://github.com/glours) in [#&#8203;13250](docker/compose#13250)
- gha: update test-matrix: remove docker 26.x by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13254](docker/compose#13254)
- pkg/compose: explicitly map AuthConfig fields instead of a direct cast by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13253](docker/compose#13253)
- cmd/compose: fix minor linting issues by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13252](docker/compose#13252)
- use containerd client for OCI operations by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13251](docker/compose#13251)
##### ⚙️ Dependencies
- build(deps): bump github.com/docker/docker, docker/cli v28.5.0-rc.1 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13241](docker/compose#13241)
- build(deps): bump github.com/docker/docker from 28.5.0-rc.1+incompatible to 28.5.0+incompatible by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13260](docker/compose#13260)
- build(deps): bump github.com/docker/cli from 28.5.0-rc.1+incompatible to 28.5.0+incompatible by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13261](docker/compose#13261)
**Full Changelog**: <docker/compose@v2.39.4...v2.40.0>
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzIuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gloursgloursglours approved these changes
@ndeloofndeloofAwaiting requested review from ndeloofndeloof is a code owner automatically assigned from docker/compose-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah@glours