gets back runtime flags when configuring models by ilopezluna · Pull Request #13460 · docker/compose

ilopezluna · 2025-12-16T11:16:51Z

What I did
This pull reverts the changes of the model configuration that disabled --runtime-args

Related issue
docker/model-runner#515

Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

doringeman

Thanks!
FWIW this reverts #13404.

ndeloof

#13404 was introduced for security reasons, restoring support for those flags should only be allowed when the docker-model CLI matches a version that comes with security fix.

Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

…s and store plugin version obtained by pluginManager in newModelAPI Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

codecov · 2025-12-17T18:47:16Z

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/compose/model.go	0.00%	22 Missing ⚠️

📢 Thoughts on this report? Let us know!

ndeloof · 2025-12-18T07:31:15Z

+	versionStr := strings.TrimPrefix(m.version, "v")
+
+	// Strip build metadata or prerelease suffix after "-" or "+"
+	// This is necessary because versions.LessThan treats "1.0.6-dirty" < "1.0.6" per semver rules


model-runner 1.0.6 has been released, so is this still relevant ?

This is helpful for anyone using the Docker Model CLI built locally. I can remove it if you prefer, I just thought it might be useful in some cases. Do you see any downside?

latest tag is v1.0.10 so it doesn't seem this would be useful, even in development mode.

DMR tag is v1.0.10
Docker Model CLI is v1.0.6https://github.com/docker/model-runner/releases/tag/cmd%2Fcli%2Fv1.0.6
Anyway, I remove it.

Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

…o revert-reject-runtime-flags

Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v5.0.1` → `v5.0.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v5.0.2`](https://github.com/docker/compose/releases/tag/v5.0.2) [Compare Source](docker/compose@v5.0.1...v5.0.2) #### What's Changed ##### 🐛 Fixes - Fixed progress UI to adapt to terminal width by [@ndeloof](https://github.com/ndeloof) in [#13519](docker/compose#13519) - Removed warning when no explicit build has been requested. by [@ndeloof](https://github.com/ndeloof) in [#13493](docker/compose#13493) - Restored `runtime_flags` support in `models` by [@ilopezluna](https://github.com/ilopezluna) in [#13460](docker/compose#13460) - Added service name completion to `down` command by [@bmo-at](https://github.com/bmo-at) in [#13470](docker/compose#13470) - Fixed tilde in `--env-file` paths expanded to user home directory by [@tensorworkerr](https://github.com/tensorworkerr) in [#13510](docker/compose#13510) - Handle `healthcheck.disable: true` by [@stavros-k](https://github.com/stavros-k) in [#13494](docker/compose#13494) - Fixed shutdown and error handling for large file change batches in `watch` by [@amyssnippet](https://github.com/amyssnippet) in [#13525](docker/compose#13525) ##### 🔧 Internal - Added unit test for upOptions.OnExit method by [@htoyoda18](https://github.com/htoyoda18) in [#13489](docker/compose#13489) - clean up temporary compose files after conversion by [@htoyoda18](https://github.com/htoyoda18) in [#13483](docker/compose#13483) - Fixed typo in isSwarmEnabled method name by [@htoyoda18](https://github.com/htoyoda18) in [#13481](docker/compose#13481) - Fixed incorrect usage of errgroup.WithContext by [@htoyoda18](https://github.com/htoyoda18) in [#13480](docker/compose#13480) - Fixed timeout initialization when waitTimeout is zero by [@htoyoda18](https://github.com/htoyoda18) in [#13471](docker/compose#13471) - Extracted API version constants to dedicated file by [@htoyoda18](https://github.com/htoyoda18) in [#13503](docker/compose#13503) - Replace tabbed indentation in sdk.md by [@pkqk](https://github.com/pkqk) in [#13505](docker/compose#13505) - Improved attach error handling and cleanup by [@htoyoda18](https://github.com/htoyoda18) in [#13488](docker/compose#13488) - Modernize tests by [@dgageot](https://github.com/dgageot) in [#13531](docker/compose#13531) - set fsnotify build tag when building for OSX by [@ndeloof](https://github.com/ndeloof) in [#13532](docker/compose#13532) ##### ⚙️ Dependencies - build(deps): bump github.com/klauspost/compress to v1.18.2 by [@thaJeztah](https://github.com/thaJeztah) in [#13499](docker/compose#13499) - go.mod: remove exclude rules by [@thaJeztah](https://github.com/thaJeztah) in [#13498](docker/compose#13498) - build(deps): bump github.com/containerd/containerd/v2 to v2.2.1 by [@thaJeztah](https://github.com/thaJeztah) in [#13497](docker/compose#13497) - build(deps): bump golang.org/x/sys from 0.39.0 to 0.40.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13502](docker/compose#13502) - build(deps): bump google.golang.org/grpc from 1.77.0 to 1.78.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13475](docker/compose#13475) - build(deps): bump github.com/go-viper/mapstructure/v2 from 2.4.0 to 2.5.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#13506](docker/compose#13506) - build(deps): bump github.com/sirupsen/logrus v1.9.4 by [@thaJeztah](https://github.com/thaJeztah) in [#13518](docker/compose#13518) - Bump compose to v2.10.1 by [@ndeloof](https://github.com/ndeloof) in [#13528](docker/compose#13528) #### New Contributors - [@bmo-at](https://github.com/bmo-at) made their first contribution in [#13470](docker/compose#13470) - [@pkqk](https://github.com/pkqk) made their first contribution in [#13505](docker/compose#13505) - [@tensorworkerr](https://github.com/tensorworkerr) made their first contribution in [#13510](docker/compose#13510) - [@stavros-k](https://github.com/stavros-k) made their first contribution in [#13494](docker/compose#13494) - [@amyssnippet](https://github.com/amyssnippet) made their first contribution in [#13525](docker/compose#13525) - [@dgageot](https://github.com/dgageot) made their first contribution in [#13531](docker/compose#13531) **Full Changelog**: <docker/compose@v5.0.1...v5.0.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

@ndeloof

Fixed progress UI to adapt to terminal width by @ndeloof in docker/compose#13519 Removed warning when no explicit build has been requested. by @ndeloof in docker/compose#13493 Restored runtime_flags support in models by @ilopezluna in docker/compose#13460 Added service name completion to down command by @bmo-at in docker/compose#13470 Fixed tilde in --env-file paths expanded to user home directory by @tensorworkerr in docker/compose#13510 Handle healthcheck.disable: true by @stavros-k in docker/compose#13494 Fixed shutdown and error handling for large file change batches in watch by @amyssnippet in docker/compose#13525 Signed-off-by: David Mandy <smallprogramzhusir@gmail.com>

gets back runtime flags when configuring models
8459415
Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

ilopezluna requested a review from a team as a code owner December 16, 2025 11:16

ilopezluna requested review from glours and ndeloof December 16, 2025 11:16

doringeman approved these changes Dec 16, 2025
View reviewed changes

ilopezluna marked this pull request as draft December 16, 2025 11:41

ndeloof requested changes Dec 16, 2025
View reviewed changes

Only append RuntimeFlags if docker model CLI version is >= v1.0.6
6a52878
Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

ndeloof reviewed Dec 17, 2025
View reviewed changes

Comment threadpkg/compose/model.go Outdated

ndeloof reviewed Dec 17, 2025
View reviewed changes

Comment threadpkg/compose/model.go Outdated

use github.com/docker/docker/api/types/versions for comparing version…
3cdd1e6
…s and store plugin version obtained by pluginManager in newModelAPI Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

ilopezluna marked this pull request as ready for review December 17, 2025 16:40

ilopezluna requested a review from ndeloof December 17, 2025 16:40

Merge branch 'main' into revert-reject-runtime-flags
e447d91

ilopezluna mentioned this pull request Dec 17, 2025
Facing Issues with setting runtime_flags in Docker Compose docker/model-runner#515
Closed

ndeloof reviewed Dec 18, 2025
View reviewed changes

ilopezluna requested a review from ndeloof December 18, 2025 08:54

ilopezluna added 3 commits December 18, 2025 11:50

do not strip build metadata
db04dc5
Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

Merge remote-tracking branch 'origin/revert-reject-runtime-flags' int…
0c8be12
…o revert-reject-runtime-flags

Merge branch 'main' into revert-reject-runtime-flags
3e6ac35

doringeman reviewed Dec 18, 2025
View reviewed changes

Comment threadpkg/compose/model.go Outdated

remove duplicated version field
5cdf55a
Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

ndeloof approved these changes Dec 18, 2025
View reviewed changes

ndeloof merged commit 59f04b8 into docker:mainDec 18, 2025
24 checks passed

BrewTestBot mentioned this pull request Jan 21, 2026
docker-compose 5.0.2 Homebrew/homebrew-core#263803
Merged

rancherbot mentioned this pull request Jan 21, 2026
rddepman: bump dockerCompose from 5.0.1 to 5.0.2 rancher-sandbox/rancher-desktop#9778
Merged

smallprogram mentioned this pull request Jan 29, 2026
docker-compose: bump to 5.0.2 openwrt/packages#28455
Closed
1 task

Navigation Menu

Uh oh!

gets back runtime flags when configuring models - #13460

gets back runtime flags when configuring models#13460
ndeloof merged 8 commits into
docker:mainfrom
ilopezluna:revert-reject-runtime-flags

ilopezluna commented Dec 16, 2025

Uh oh!

doringeman left a comment

Uh oh!

ndeloof left a comment

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Dec 17, 2025

Uh oh!

ndeloofDec 18, 2025

Uh oh!

ilopezlunaDec 18, 2025

Uh oh!

ndeloofDec 18, 2025

Uh oh!

ilopezlunaDec 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ilopezluna commented Dec 16, 2025

Uh oh!

doringeman left a comment

Choose a reason for hiding this comment

Uh oh!

ndeloof left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Dec 17, 2025

Codecov Report

Uh oh!

ndeloofDec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ilopezlunaDec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ndeloofDec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ilopezlunaDec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants