Uh oh!
There was an error while loading. Please reload this page.
Introduce schema for compose's configuration file. - #1348
Conversation
Note that the validation is done after the configuration is converted to Python so the validation should work for any file format. Handles #129. Signed-off-by: Raghuram Devarakonda <draghuram@gmail.com>
funkyfuture
commented
Apr 24, 2015
related to #129 |
funkyfuture
commented
Apr 25, 2015
thanks for sharing that approach. after a first review, here are some thoughts:
@aanand@bfirsh@dnephin@draghuram i'd appreciate any feedback before i get on it. |
aanand
commented
Apr 27, 2015
Thanks for both your PRs - I'm going to take a proper look at them soon. |
aanand
commented
Apr 29, 2015
This looks like a good start. I don't feel especially strongly about this one vs @funkyfuture's so if you've not got the time, that one will probably win by default. I know @dnephin has advocated for using JSON schema in the past and I can see a hypothetical argument for it (should the Compose format ever become something that's serializable to JSON) but I don't think it's a particularly strong one. |
draghuram
commented
Apr 29, 2015
@aanand Thanks for the comments. I agree that we should go with @funkyfuture's PR considering that he is willing to see the feature through. |
mnowster
commented
Aug 19, 2015
Handled by #1808 |
I haven't been able to work on this of late so I am creating this PR in the hope that some one else can take it forward.