Uh oh!
There was an error while loading. Please reload this page.
Tolerate missing env file on more runtime commands - #13603
Merged
Conversation
ndeloof
previously approved these changes
Feb 23, 2026
ndeloof
enabled auto-merge (rebase)
February 23, 2026 07:34
gloursforce-pushed
the
feature/13601-runtime-ops
branch
from
March 31, 2026 14:05
ed6a96d to
3a8ff9cCompareglours
commented
Mar 31, 2026
Contributor
Hey @maxproske 👋 |
maxproske
commented
Jul 20, 2026
ContributorAuthor
@glours Could I please get a reopen here? |
This issue has been automatically marked as not stale anymore due to the recent activity. |
1 similar comment
This issue has been automatically marked as not stale anymore due to the recent activity. |
glours
commented
Jul 20, 2026
Contributor
@maxproske done |
Signed-off-by: Max Proske <max@mproske.com>
maxproskeforce-pushed
the
feature/13601-runtime-ops
branch
from
July 25, 2026 21:16
3a8ff9c to
b1a0dfbComparemaxproske
commented
Jul 25, 2026
ContributorAuthor
@glours Thanks! Fixed test order on previously approved changes |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
glours added a commit
that referenced
this pull request
Jul 30, 2026
Follow-up to #13603: scale, watch and shell completion loaded the project without any tolerance option, so a missing env_file on a service not involved in the operation aborted the command, while up/exec/ps already tolerate this since #13156 and #13603. Mirror the WithServices pattern: load with WithoutEnvironmentResolution and resolve the environment once the project has been reduced to the selected services, so targeted services still get their env_file validated. Completion only needs names and never resolves. This also aligns the config hash of scale-created containers with up-created ones. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Align toProjectName (used by exec, image, etc.) with projectOrName (used by ps, logs, etc.), which already had these flags since #13156
I know, this skips compose.yaml parsing. Being pragmatic for now, as I haven't touched compose-go yet, but can probably add a function to avoid the need to call ToProject at all.
Related issue
Closes#13601