Reconciliation plan

[ndeloof]

this is an alternative for #13641
based on previous work, I first generated an analysis an plan document, so AI work on this significant refactoring is better guided and impact is well understood

[codecov]

Codecov Report

❌ Patch coverage is 79.78022% with 184 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/compose/reconcile.go	79.13%	73 Missing and 19 partials ⚠️
pkg/compose/executor_ops.go	64.70%	27 Missing and 3 partials ⚠️
pkg/compose/executor_events.go	77.77%	21 Missing and 1 partial ⚠️
pkg/compose/executor.go	80.00%	14 Missing ⚠️
pkg/compose/observed_state.go	88.46%	6 Missing and 6 partials ⚠️
pkg/compose/convergence.go	68.18%	5 Missing and 2 partials ⚠️
pkg/compose/run.go	50.00%	1 Missing and 2 partials ⚠️
pkg/compose/containers.go	77.77%	1 Missing and 1 partial ⚠️
pkg/compose/create.go	85.71%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[ndeloof]

/review

[Copilot]

Pull request overview

Introduces a new “reconciliation plan” pipeline for docker compose create by replacing the legacy convergence flow with: observed state collection → plan generation (DAG) → parallel plan execution.

Changes:

• Added new reconciliation components: ObservedState, Plan, reconcile logic, and a parallel executePlan executor with grouped progress events.
• Refactored create() to use the new pipeline (including “Running” events for unchanged containers) and removed most of the old convergence implementation.
• Updated run to resolve service: references without convergence, and added/updated unit tests for the new modules.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
reconciliation.md	Architecture/design doc for the new reconciliation engine and pipeline.
pkg/compose/run.go	Replaces convergence-based service-reference resolution for run with a new helper.
pkg/compose/reconcile_test.go	Adds unit tests validating plan output for networks/volumes/containers/orphans.
pkg/compose/reconcile.go	Implements reconciler producing a deterministic DAG plan for infra + containers.
pkg/compose/progress.go	Removes runningEvent helper (replaced by direct newEvent usage).
pkg/compose/plan_test.go	Adds unit tests for Plan and OperationType stringification.
pkg/compose/plan.go	Introduces Plan, PlanNode, Operation, and OperationType abstractions.
pkg/compose/observed_state_test.go	Adds tests for observed-state snapshot construction and classification.
pkg/compose/observed_state.go	Adds snapshot types + collection logic; adds “Running” events emission helper.
pkg/compose/executor_test.go	Adds executor tests using mocked API client calls.
pkg/compose/executor.go	Implements parallel plan execution, operation handlers, and grouped progress events.
pkg/compose/create.go	Refactors create() to build observed state → reconcile → emit running events → execute plan.
pkg/compose/convergence.go	Removes convergence struct/logic; keeps/exports service-reference resolution helpers.
pkg/compose/containers.go	Adds getContainersByService() and removes Containers.names().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Spelling: "inchange" should be "inchangé".

[glours]

/review

[docker-agent]

❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs.

[glours]

/review

[docker-agent]

❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs.