Skip to content

Modified scale awareness from exception to warning - #1466

Merged
aanand merged 1 commit into
docker:masterfrom
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged

Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom
noironetworks:changing-scale-to-warning

Conversation

@aanm

@aanmaanm commented May 26, 2015

Copy link
Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378
Signed-off-by: André Martins martins@noironetworks.com

@aanm
aanmforce-pushed the changing-scale-to-warning branch from 6d5ff62 to 2538283CompareMay 26, 2015 22:37
@aanmaanm mentioned this pull request May 26, 2015
Closed
@dnephin

dnephin commented May 26, 2015

Copy link
Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.

aanand
aanand reviewed May 26, 2015
View reviewed changes
Comment threadcompose/service.py Outdated

@aanandaanandMay 26, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".

@aanmaanmMay 26, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"

@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed the changing-scale-to-warning branch from 2538283 to ae63d35CompareMay 26, 2015 23:00
@dnephin

dnephin commented Jun 4, 2015

Copy link
Copy Markdown

LGTM

1 similar comment
@aanand

aanand commented Jun 4, 2015

Copy link
Copy Markdown

LGTM

aanand added a commit that referenced this pull request Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand merged commit 7d2a894 into docker:masterJun 4, 2015
@dnephindnephin added this to the 1.4.0 milestone Jun 4, 2015
@aanandaanand modified the milestone: 1.4.0Jun 4, 2015
@chanwit

chanwit commented Jun 6, 2015

Copy link
Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)

@aanand

aanand commented Jun 10, 2015

Copy link
Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?

@bfirsh

bfirsh commented Jun 10, 2015

Copy link
Copy Markdown

👍

@aanandaanand modified the milestones: 1.3.0, 1.4.0Jun 10, 2015
@aanand

aanand commented Jun 10, 2015

Copy link
Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).

@chanwit

chanwit commented Jun 10, 2015 via email

Copy link
Copy Markdown

aanand added a commit to aanand/fig that referenced this pull request Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit to aanand/fig that referenced this pull request Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin mentioned this pull request Jun 19, 2015
Closed
@wader

wader commented Jun 25, 2015

Copy link
Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?

@aanm
aanm deleted the changing-scale-to-warning branch December 21, 2015 07:43
infraAnchor pushed a commit to infraAnchor/compose that referenced this pull request Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity

7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Modified scale awareness from exception to warning by aanm · Pull Request #1466 · docker/compose · GitHub
Skip to content
Modified scale awareness from exception to warning - #1466
Merged
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged
Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Conversation
@aanm
@aanmaanm
commented
May 26, 2015

Copy link


Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378

Signed-off-by: André Martins martins@noironetworks.com
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283CompareMay 26, 2015 22:37
@aanmaanm
mentioned this pull request
May 26, 2015
 Closed

@dnephin
dnephin
commented
May 26, 2015

Copy link


Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.
aanand
aanand
reviewed
May 26, 2015
 View reviewed changes

Comment threadcompose/service.py
Outdated

@aanandaanandMay 26, 2015

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".
@aanmaanmMay 26, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"
@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35CompareMay 26, 2015 23:00
@dnephin
dnephin
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand
merged commit 7d2a894
into
docker:masterJun 4, 2015
@dnephindnephin
added this to the 1.4.0 milestone
Jun 4, 2015
@aanandaanand
modified the milestone:
1.4.0Jun 4, 2015
@chanwit
chanwit
commented
Jun 6, 2015

Copy link


Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?
@bfirsh
bfirsh
commented
Jun 10, 2015

Copy link


Copy Markdown

👍
@aanandaanand
modified the milestones:
1.3.0, 1.4.0Jun 10, 2015
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).
@chanwit
chanwit
commented
Jun 10, 2015
via email 

Copy link


Copy Markdown

aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin
mentioned this pull request
Jun 19, 2015

Closed

@wader
wader
commented
Jun 25, 2015

Copy link


Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?
@aanm
aanm
deleted the

changing-scale-to-warning

branch
December 21, 2015 07:43
infraAnchor pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity


7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Modified scale awareness from exception to warning by aanm · Pull Request #1466 · docker/compose · GitHub
Skip to content
Modified scale awareness from exception to warning - #1466
Merged
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged
Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Conversation
@aanm
@aanmaanm
commented
May 26, 2015

Copy link


Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378

Signed-off-by: André Martins martins@noironetworks.com
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283CompareMay 26, 2015 22:37
@aanmaanm
mentioned this pull request
May 26, 2015
 Closed

@dnephin
dnephin
commented
May 26, 2015

Copy link


Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.
aanand
aanand
reviewed
May 26, 2015
 View reviewed changes

Comment threadcompose/service.py
Outdated

@aanandaanandMay 26, 2015

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".
@aanmaanmMay 26, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"
@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35CompareMay 26, 2015 23:00
@dnephin
dnephin
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand
merged commit 7d2a894
into
docker:masterJun 4, 2015
@dnephindnephin
added this to the 1.4.0 milestone
Jun 4, 2015
@aanandaanand
modified the milestone:
1.4.0Jun 4, 2015
@chanwit
chanwit
commented
Jun 6, 2015

Copy link


Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?
@bfirsh
bfirsh
commented
Jun 10, 2015

Copy link


Copy Markdown

👍
@aanandaanand
modified the milestones:
1.3.0, 1.4.0Jun 10, 2015
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).
@chanwit
chanwit
commented
Jun 10, 2015
via email 

Copy link


Copy Markdown

aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin
mentioned this pull request
Jun 19, 2015

Closed

@wader
wader
commented
Jun 25, 2015

Copy link


Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?
@aanm
aanm
deleted the

changing-scale-to-warning

branch
December 21, 2015 07:43
infraAnchor pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity


7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Modified scale awareness from exception to warning by aanm · Pull Request #1466 · docker/compose · GitHub
Skip to content
Modified scale awareness from exception to warning - #1466
Merged
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged
Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Conversation
@aanm
@aanmaanm
commented
May 26, 2015

Copy link


Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378

Signed-off-by: André Martins martins@noironetworks.com
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283CompareMay 26, 2015 22:37
@aanmaanm
mentioned this pull request
May 26, 2015
 Closed

@dnephin
dnephin
commented
May 26, 2015

Copy link


Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.
aanand
aanand
reviewed
May 26, 2015
 View reviewed changes

Comment threadcompose/service.py
Outdated

@aanandaanandMay 26, 2015

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".
@aanmaanmMay 26, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"
@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35CompareMay 26, 2015 23:00
@dnephin
dnephin
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand
merged commit 7d2a894
into
docker:masterJun 4, 2015
@dnephindnephin
added this to the 1.4.0 milestone
Jun 4, 2015
@aanandaanand
modified the milestone:
1.4.0Jun 4, 2015
@chanwit
chanwit
commented
Jun 6, 2015

Copy link


Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?
@bfirsh
bfirsh
commented
Jun 10, 2015

Copy link


Copy Markdown

👍
@aanandaanand
modified the milestones:
1.3.0, 1.4.0Jun 10, 2015
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).
@chanwit
chanwit
commented
Jun 10, 2015
via email 

Copy link


Copy Markdown

aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin
mentioned this pull request
Jun 19, 2015

Closed

@wader
wader
commented
Jun 25, 2015

Copy link


Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?
@aanm
aanm
deleted the

changing-scale-to-warning

branch
December 21, 2015 07:43
infraAnchor pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity


7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Modified scale awareness from exception to warning by aanm · Pull Request #1466 · docker/compose · GitHub
Skip to content
Modified scale awareness from exception to warning - #1466
Merged
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged
Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Conversation
@aanm
@aanmaanm
commented
May 26, 2015

Copy link


Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378

Signed-off-by: André Martins martins@noironetworks.com
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283CompareMay 26, 2015 22:37
@aanmaanm
mentioned this pull request
May 26, 2015
 Closed

@dnephin
dnephin
commented
May 26, 2015

Copy link


Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.
aanand
aanand
reviewed
May 26, 2015
 View reviewed changes

Comment threadcompose/service.py
Outdated

@aanandaanandMay 26, 2015

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".
@aanmaanmMay 26, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"
@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35CompareMay 26, 2015 23:00
@dnephin
dnephin
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand
merged commit 7d2a894
into
docker:masterJun 4, 2015
@dnephindnephin
added this to the 1.4.0 milestone
Jun 4, 2015
@aanandaanand
modified the milestone:
1.4.0Jun 4, 2015
@chanwit
chanwit
commented
Jun 6, 2015

Copy link


Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?
@bfirsh
bfirsh
commented
Jun 10, 2015

Copy link


Copy Markdown

👍
@aanandaanand
modified the milestones:
1.3.0, 1.4.0Jun 10, 2015
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).
@chanwit
chanwit
commented
Jun 10, 2015
via email 

Copy link


Copy Markdown

aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin
mentioned this pull request
Jun 19, 2015

Closed

@wader
wader
commented
Jun 25, 2015

Copy link


Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?
@aanm
aanm
deleted the

changing-scale-to-warning

branch
December 21, 2015 07:43
infraAnchor pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity


7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Modified scale awareness from exception to warning by aanm · Pull Request #1466 · docker/compose · GitHub
Skip to content
Modified scale awareness from exception to warning - #1466
Merged
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged
Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Conversation
@aanm
@aanmaanm
commented
May 26, 2015

Copy link


Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378

Signed-off-by: André Martins martins@noironetworks.com
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283CompareMay 26, 2015 22:37
@aanmaanm
mentioned this pull request
May 26, 2015
 Closed

@dnephin
dnephin
commented
May 26, 2015

Copy link


Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.
aanand
aanand
reviewed
May 26, 2015
 View reviewed changes

Comment threadcompose/service.py
Outdated

@aanandaanandMay 26, 2015

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".
@aanmaanmMay 26, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"
@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35CompareMay 26, 2015 23:00
@dnephin
dnephin
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand
merged commit 7d2a894
into
docker:masterJun 4, 2015
@dnephindnephin
added this to the 1.4.0 milestone
Jun 4, 2015
@aanandaanand
modified the milestone:
1.4.0Jun 4, 2015
@chanwit
chanwit
commented
Jun 6, 2015

Copy link


Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?
@bfirsh
bfirsh
commented
Jun 10, 2015

Copy link


Copy Markdown

👍
@aanandaanand
modified the milestones:
1.3.0, 1.4.0Jun 10, 2015
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).
@chanwit
chanwit
commented
Jun 10, 2015
via email 

Copy link


Copy Markdown

aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin
mentioned this pull request
Jun 19, 2015

Closed

@wader
wader
commented
Jun 25, 2015

Copy link


Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?
@aanm
aanm
deleted the

changing-scale-to-warning

branch
December 21, 2015 07:43
infraAnchor pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity


7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Modified scale awareness from exception to warning by aanm · Pull Request #1466 · docker/compose · GitHub
Skip to content
Modified scale awareness from exception to warning - #1466
Merged
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Jun 4, 2015
Merged
Modified scale awareness from exception to warning#1466
aanand merged 1 commit into
docker:masterfrom 
noironetworks:changing-scale-to-warning
Conversation
@aanm
@aanmaanm
commented
May 26, 2015

Copy link


Copy Markdown

It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378

Signed-off-by: André Martins martins@noironetworks.com
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283CompareMay 26, 2015 22:37
@aanmaanm
mentioned this pull request
May 26, 2015
 Closed

@dnephin
dnephin
commented
May 26, 2015

Copy link


Copy Markdown

I think this is a good idea. I'll defer to others about the text of the warning.
aanand
aanand
reviewed
May 26, 2015
 View reviewed changes

Comment threadcompose/service.py
Outdated

@aanandaanandMay 26, 2015

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear warning, but I don't think we need "only".
@aanmaanmMay 26, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, makes more sense without the "only"
@aanm
Modified scale awareness from exception to warning
ae63d35
Signed-off-by: André Martins <martins@noironetworks.com>
@aanm
aanmforce-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35CompareMay 26, 2015 23:00
@dnephin
dnephin
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM

1 similar comment

@aanand
aanand
commented
Jun 4, 2015

Copy link


Copy Markdown

LGTM
aanand added a commit
that referenced
this pull request
Jun 4, 2015
@aanand
Merge pull request#1466from noironetworks/changing-scale-to-warning
7d2a894
Modified scale awareness from exception to warning
@aanand
aanand
merged commit 7d2a894
into
docker:masterJun 4, 2015
@dnephindnephin
added this to the 1.4.0 milestone
Jun 4, 2015
@aanandaanand
modified the milestone:
1.4.0Jun 4, 2015
@chanwit
chanwit
commented
Jun 6, 2015

Copy link


Copy Markdown

@aanand@dnephin This is a trivial change, but important. Is it possible to include this change into 1.3? (I know it's a bit late - sorry for that)
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3?
@bfirsh
bfirsh
commented
Jun 10, 2015

Copy link


Copy Markdown

👍
@aanandaanand
modified the milestones:
1.3.0, 1.4.0Jun 10, 2015
@aanand
aanand
commented
Jun 10, 2015

Copy link


Copy Markdown

Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up).
@chanwit
chanwit
commented
Jun 10, 2015
via email 

Copy link


Copy Markdown

aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
00167b4
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
@aanand
Merge pull requestdocker#1466from noironetworks/changing-scale-to-w…
cd7f670
…arning
Modified scale awareness from exception to warning
(cherry picked from commit 7d2a894)
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@dnephindnephin
mentioned this pull request
Jun 19, 2015

Closed

@wader
wader
commented
Jun 25, 2015

Copy link


Copy Markdown

It should be possible to use scale and ip::containerPort format right? adjust can_be_scaled?
@aanm
aanm
deleted the

changing-scale-to-warning

branch
December 21, 2015 07:43
infraAnchor pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
@prombot
Update common Prometheus files (docker#1466)
6f48a98
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Allow scaling services with static ports on Swarm with affinity


7 participants

@aanm@dnephin@aanand@chanwit@bfirsh@wader@GordonTheTurtle