') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Port ranges by mnowster · Pull Request #1827 · docker/compose · GitHub
Skip to content

Port ranges - #1827

Merged
aanand merged 4 commits into
docker:masterfrom
mnowster:port-ranges
Aug 12, 2015
Merged

Port ranges#1827
aanand merged 4 commits into
docker:masterfrom
mnowster:port-ranges

Conversation

@mnowster

Copy link
Copy Markdown

Add port range support to docker compose.

Allows us to remove our split_port function and use docker-py's split_port function.

yuval-kand others added 4 commits August 7, 2015 16:22
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
@mnowstermnowster added this to the 1.5.0 milestone Aug 7, 2015
@aanand

Copy link
Copy Markdown

LGTM.

@uvgroovy @mnowster: Thanks team!

aanand added a commit that referenced this pull request Aug 12, 2015
@aanand
aanand merged commit ed31673 into docker:masterAug 12, 2015
@mnowster

Copy link
Copy Markdown
Author

Yay! Yes, thank you @uvgroovy for your helpful contribution ✨

@mnowster
mnowster deleted the port-ranges branch August 12, 2015 15:07
@dnephindnephin mentioned this pull request Sep 4, 2015
@tequilaskywalk

tequilaskywalk commented Jun 23, 2016

Copy link
Copy Markdown

why is this missing in 1.8.0-rc1 (build 9bf6bc9 )?

OSX: Native Docker Version 1.12.0-rc2-beta16 (build: 9493)
f615be9fb245904fbdf1aa0cad251d418c869428

Edit: I am experiencing the issue when defining port ranges like so:

docker-compose.yml snippet

version: "2"
services:
serviceA:
ports:
- "5000-6000:5000-6000"

@aanand

Copy link
Copy Markdown

@tequilaskywalk This has been in Compose for several versions now. I just tried your example on Docker for Mac and it crashed the VM. My guess would be that simultaneously binding 1001 ports puts a bit of a strain on it.

@ellioseven

Copy link
Copy Markdown

This still seems to be an issue for me? Am I

[example] cat docker-compose.yml # PHP Web Server
web:
# Build the Drupal 8 image# https://hub.docker.com/r/_/drupal/
image: drupal:8
# Environment variables
environment:
# Drupal settings
DRUPAL_PROFILE: standard
DRUPAL_SITE_NAME: Drupal
DRUPAL_USER: admin
DRUPAL_PASS: admin
DRUPAL_DBURL: mysql://drupal:drupal@database:3406/drupal
ports:
# Host machine's port 8000 will map to Drupal's port 80
- "8000-8100:80"
volumes:
# Drupal should live in the "drupal" directory
- ./drupal:/app
links:
- database:database
command: php -S 0.0.0.0:80 -t /app
working_dir: /app
restart: always
# MySQL Server
database:
image: mysql:5
environment:
MYSQL_USER: drupal
MYSQL_PASSWORD: drupal
MYSQL_DATABASE: drupal
MYSQL_ROOT_PASSWORD: ''
MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
ports:
- "3306-3406:3306"
volumes:
- ./mysql:/var/lib/mysql
restart: always
[example] docker-compose up ERROR: The Compose file './docker-compose.yml' is invalid because:
database.ports is invalid: Port ranges don't match in lengthweb.ports is invalid: Port ranges don't match in length
[example] docker-compose --version docker-compose version 1.7.1, build 0a9ab35
[example] docker --version Docker version 1.11.2, build b9f10c9

@aanand

Copy link
Copy Markdown

@ellioseven We don't yet support mapping a range on the host to a single container port. This is tracked in #3150.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mnowster@aanand@tequilaskywalk@ellioseven@GordonTheTurtle@yuval-k