') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add support for the --entrypoint option of docker run by suzaku · Pull Request #414 · docker/compose · GitHub
Skip to content

Add support for the --entrypoint option of docker run - #414

Closed
suzaku wants to merge 1 commit into
docker:masterfrom
suzaku:support_entrypoint
Closed

Add support for the --entrypoint option of docker run#414
suzaku wants to merge 1 commit into
docker:masterfrom
suzaku:support_entrypoint

Conversation

@suzaku

@suzakusuzaku commented Aug 17, 2014

Copy link
Copy Markdown

We can use command in fig.yml to override the default command, but this won't work if the docker image we are working with specifies a ENTRYPOINT for its containers.

In my case, the Dockerfile of the main service has specified something like ["gunicorn", "-c", "config.py"] as its ENTRYPOINT, so I can't do things like python manage.py syncdb if I can't override the ENTRYPOINT.

Entrypoints can be overrdden by the --entrypoint option, this PR attempts to solve the problem by exposing this option in fig.

@salehe

salehe commented Aug 17, 2014

Copy link
Copy Markdown

Isn't this already supported in fig.yml with 'entrypoint' key? Does this PR intend to make this available on fig CLI?

@suzaku

suzaku commented Aug 17, 2014

Copy link
Copy Markdown
Author

@salehe Yes, since some images have specified ENTRYPOINT in their Dockerfiles, we cannot always override the command using CMD only.

@dnephin

dnephin commented Aug 18, 2014

Copy link
Copy Markdown

This is related to #363

suzaku
suzaku reviewed Aug 19, 2014
View reviewed changes
Comment threadfig/container.py

@suzakusuzakuAug 19, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnephin Thanks for replying. Isn't this a function that return some information about an already running container? What do you mean by "this"?

@dnephindnephinAug 19, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes

@suzaku
Add support for the --entrypoint option of docker run
1751899
Signed-off-by: Satoru Logic <satorulogic@gmail.com>
@suzaku

suzaku commented Aug 20, 2014

Copy link
Copy Markdown
Author

@salehe Are you a core developer of fig?

@salehe

salehe commented Aug 20, 2014

Copy link
Copy Markdown

No! I'm just a contributer @suzaku

@prologic

prologic commented Aug 22, 2014

Copy link
Copy Markdown

+1

bfirsh
bfirsh reviewed Sep 12, 2014
View reviewed changes
Comment threadfig/cli/main.py

@bfirshbfirshSep 12, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentionally 80 chars wide!

@bfirshbfirsh mentioned this pull request Oct 1, 2014
Merged
@bfirsh

bfirsh commented Oct 1, 2014

Copy link
Copy Markdown

Replaced by #511

@bfirshbfirsh closed this Oct 1, 2014
xulike666 pushed a commit to xulike666/compose that referenced this pull request Jan 19, 2017
@stevvooe
Merge pull requestdocker#414from samuelkarp/snapshot-tests
9a740a0
snapshot: Fix leaked mounts and temp directories
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suzaku@salehe@dnephin@prologic@bfirsh