Uh oh!
There was an error while loading. Please reload this page.
Conversation
Specifying a key of "template" within a service can refer to another yml file causing the service to "override" another service in the template file. The value of template can either be a string, which refers to a service of the same name in another yml file, or a dict consisting of two keys: "service" and "path". Signed-off-by: Gerald Kaszuba <gak@gak0.com>
There were a few bugs in my initial implementation: - Infinite recursion when referring to the same template file. Implementing a class and caching previously loaded yml files handles that problem. - Dictionaries that were updated in place where left "dirty". The copy.copy fixes that. - Incorrectly configured template yml files were not throwing fig exceptions. Signed-off-by: Gerald Kaszuba <gak@gak0.com>
Signed-off-by: Gerald Kaszuba <gak@gak0.com>
Signed-off-by: Gerald Kaszuba <gak@gak0.com>
vdemeester
commented
May 11, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #761 for details.