Skip to content

Fix bind mounts when in project volumes definition - #9514

Merged
glours merged 1 commit into
docker:v2from
ulyssessouza:fix-bindmounts
Jun 9, 2022
Merged

Fix bind mounts when in project volumes definition#9514
glours merged 1 commit into
docker:v2from
ulyssessouza:fix-bindmounts

Conversation

@ulyssessouza

Copy link
Copy Markdown
Contributor

What I did
Fix bind mounts when in project volumes definition

This fixes the type of a volume back to a bind mount

Related issue
Resolvesdocker/for-mac#6317

Comment threadpkg/compose/create.go Outdated
Comment threadcmd/compose/compose.go Outdated
@ulyssessouza
ulyssessouzaforce-pushed the fix-bindmounts branch 3 times, most recently from 668eadf to 0ba4604CompareJune 1, 2022 21:52
@ulyssessouza
ulyssessouza requested a review from ndeloofJune 1, 2022 21:53
@ulyssessouza
ulyssessouzaforce-pushed the fix-bindmounts branch 2 times, most recently from 3baaf42 to caa88b2CompareJune 1, 2022 22:22
@ulyssessouza
ulyssessouza marked this pull request as ready for review June 1, 2022 22:29
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>

@milasmilas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gloursglours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device Bind Mount Disconnecting from Container Directory

4 participants

@ulyssessouza@ndeloof@glours@milas