Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Provide user override option on command line by IanVS · Pull Request #971 · docker/compose · GitHub
Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Provide user override option on command line by IanVS · Pull Request #971 · docker/compose · GitHub
Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Provide user override option on command line by IanVS · Pull Request #971 · docker/compose · GitHub
Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Provide user override option on command line by IanVS · Pull Request #971 · docker/compose · GitHub
Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Provide user override option on command line by IanVS · Pull Request #971 · docker/compose · GitHub
Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Provide user override option on command line by IanVS · Pull Request #971 · docker/compose · GitHub
Skip to content

Provide user override option on command line - #971

Merged
dnephin merged 1 commit into
docker:masterfrom
IanVS:master
Mar 11, 2015
Merged

Provide user override option on command line#971
dnephin merged 1 commit into
docker:masterfrom
IanVS:master

Conversation

@IanVS

Copy link
Copy Markdown

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter

Copy link
Copy Markdown

@aanand Any chance of getting this merged in?

@so0k

so0k commented Mar 4, 2015

Copy link
Copy Markdown

I'm looking for this feature at the moment as well

@aanand

Copy link
Copy Markdown

Needs rebasing - will check again after that.

@Globegitter

Copy link
Copy Markdown

@IanVS can you rebase?

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5

md5 commented Mar 4, 2015 via email

Copy link
Copy Markdown

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5

md5 commented Mar 4, 2015

Copy link
Copy Markdown

💪😣

@IanVS

IanVS commented Mar 4, 2015

Copy link
Copy Markdown
Author

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml
The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.
Based on commit f2f01e2 by @chmouel
Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS

Copy link
Copy Markdown
Author

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh

Copy link
Copy Markdown

@bfirsh

Copy link
Copy Markdown

cc @aanand@dnephin

@dnephin

Copy link
Copy Markdown

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin
dnephin merged commit c23189a into docker:masterMar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@IanVS@Globegitter@so0k@aanand@md5@bfirsh@dnephin