Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

rpm: add support for building on CentOS 8 - #148

Merged
silvin-lubecki merged 2 commits into
docker:masterfrom
thaJeztah:build_centos8
Mar 24, 2020
Merged

rpm: add support for building on CentOS 8#148
silvin-lubecki merged 2 commits into
docker:masterfrom
thaJeztah:build_centos8

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Mar 23, 2020

Copy link
Copy Markdown
Member

replaces #118

@thaJeztah

thaJeztah commented Mar 23, 2020

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki@seemethere@crosbymichael@cpuguy83 PTAL

@thaJeztahthaJeztah mentioned this pull request Mar 23, 2020
Closed
seemethere
seemethere previously approved these changes Mar 23, 2020
View reviewed changes
@crosbymichael

crosbymichael commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

LGTM

@thaJeztah

thaJeztah commented Mar 23, 2020

Copy link
Copy Markdown
MemberAuthor

Failure on arm64;

+ dnf -y install make gcc systemd libseccomp-devel
Last metadata expiration check: 0:00:37 ago on Mon Mar 23 20:30:48 2020.
Package systemd-239-18.el8_1.1.aarch64 is already installed.
No match for argument: libseccomp-devel
Error: Unable to find a match: libseccomp-devel
Makefile:64: recipe for target 'build' failed
make: *** [build] Error 1

Looks like for arm64 it's in the PowerTools repo; https://centos.pkgs.org/8/centos-appstream-x86_64/libseccomp-devel-2.4.1-1.el8.x86_64.rpm.html

Arm32 images don't seem to be available, so I'll disable that

@thaJeztah
rpm: remove obsolete sed for aarch64 repositories
2a4e8ab
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
rpm: add support for building on CentOS 8
6b278d4
armhf (arm32) is currently not supported, because no images exist
on Docker Hub for CentOS 8
For arm64, the seccomp-devel package is in the PowerTools repository,
so enabling that repository on CentOS 8
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
centos: enable PowerTools repo
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

thaJeztah commented Mar 23, 2020

Copy link
Copy Markdown
MemberAuthor

ok, updated;

  • disabled builds for arm32, because no image exists for CentOS 8 (arm32)
  • enabled the PowerTools repository so that (hopefully) arm64 completes successfully
  • removed obsolete sed for arm64

silvin-lubecki
silvin-lubecki approved these changes Mar 24, 2020
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit 4b7bddf into docker:masterMar 24, 2020
@thaJeztah
thaJeztah deleted the build_centos8 branch March 24, 2020 11:51
@thaJeztahthaJeztah mentioned this pull request Mar 25, 2020
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes
@seemethereseemethereseemethere left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@crosbymichael@seemethere@silvin-lubecki