Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 21, 2026. It is now read-only.
[TAR-514] RHEL 8 Support - #83
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
dave-tucker
commented
Mar 4, 2019
ContributorAuthor
Need to find a way to get ☝️ installed before this can be merged |
dave-tucker
commented
Mar 5, 2019
ContributorAuthor
Relates to https://github.com/docker/detritus/pull/7 |
seemethere
previously approved these changes
Mar 5, 2019
seemethere
left a comment
Contributor
There was a problem hiding this comment.
Can confirm this functions as expected:
Wrote: /root/rpmbuild/SRPMS/containerd.io-1.2.4-3.1.el8.src.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/containerd.io-1.2.4-3.1.el8.x86_64.rpm
dave-tucker
commented
Mar 5, 2019
ContributorAuthor
@seemethere I broke other RPM builds with my clumsy specfile'ing. Could you take a look to see how to fix the conditional with |
seemethere
previously approved these changes
Mar 11, 2019
dave-tucker
commented
Mar 11, 2019
ContributorAuthor
I can't approve my own PR but LGTM on green. |
This commit adds the necessary Makefile/Dockerfile changes to support packaging on RHEL 8. Notably BTRFS is disabled for containerd builds on this OS as the btrfs-progs package is not available during the beta. It may also not be available at GA. Signed-off-by: Dave Tucker <dt@docker.com> Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
seemethere
commented
Mar 11, 2019
Contributor
Alright had another push, some notes from this last one:
|
seemethere
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the necessary Makefile/Dockerfile changes to support
packaging on RHEL 8. Notably BTRFS is disabled for containerd builds on
this OS as the btrfs-progs package is not available during the beta. It
may also not be available at GA.
Signed-off-by: Dave Tucker dt@docker.com