Skip to content

Make engine scope a build time setting - #161

Closed
dhiltgen wants to merge 1 commit into
docker:masterfrom
dhiltgen:fix_scope_master
Closed

Make engine scope a build time setting#161
dhiltgen wants to merge 1 commit into
docker:masterfrom
dhiltgen:fix_scope_master

Conversation

@dhiltgen

@dhiltgendhiltgen commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

This should make it easier to change downstream builds
to change the scope.

Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com
(cherry picked from commit 7240669)
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com

Daniel Hiltgen
Make engine scope a build time setting
b54c58d
This should make it easier to change downstream builds
to change the scope.
Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
(cherry picked from commit 7240669)
Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
@thaJeztah

thaJeztah commented Feb 11, 2019

Copy link
Copy Markdown
Member

@dhiltgen@seemethere is this one still needed?

@thaJeztah

thaJeztah commented Feb 11, 2019

Copy link
Copy Markdown
Member

Answering my own question; looks like this is a backport of #160, but those changes were reverted/removed in #223 / #235

So I think this one can be closed

@thaJeztah

thaJeztah commented Mar 11, 2020

Copy link
Copy Markdown
Member

closing, as this is no longer used

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhiltgen@thaJeztah