Skip to content

[TAR-352] Add initial basis for cli-plugins (docker/app) - #309

Merged
seemethere merged 3 commits into
docker:masterfrom
seemethere:add_ploogins
Mar 8, 2019
Merged

[TAR-352] Add initial basis for cli-plugins (docker/app)#309
seemethere merged 3 commits into
docker:masterfrom
seemethere:add_ploogins

Conversation

@seemethere

@seemethereseemethere commented Mar 5, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds the base functionality for providing cli-plugins in our packaging.

Adding a plugin

Adding a plugin is pretty straightforward:

  1. Create a bash script in the root directory plugins with the extension .installer
  2. Have the .installer script implement a build and install_plugin function (those are pretty self explanatory)
  3. Have the .installer script source "$(dirname "$0")/.common at the beginning of the script
  4. Have the .installer script call build_or_install at the end of its script

Dependencies

@seemethere
Add initial rigging for cli-plugin building
85c375b
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere
seemethere requested a review from a teamMarch 5, 2019 22:44
@seemethere
Add plugin installation for DEB and RPM
b7a0a8f
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethereseemethere changed the title Add initial basis for cli-pluginsWIP Add initial basis for cli-pluginsMar 6, 2019
@seemethereseemethere changed the title WIP Add initial basis for cli-pluginsWIP [TAR-352] Add initial basis for cli-pluginsMar 6, 2019
@seemethereseemethere changed the title WIP [TAR-352] Add initial basis for cli-pluginsWIP [TAR-352] Add initial basis for cli-plugins (docker/app)Mar 6, 2019
@seemethere
seemethere removed the request for review from a teamMarch 6, 2019 00:08
@seemethere
seemethere requested a review from a teamMarch 8, 2019 19:14
@seemethereseemethere changed the title WIP [TAR-352] Add initial basis for cli-plugins (docker/app)[TAR-352] Add initial basis for cli-plugins (docker/app)Mar 8, 2019
dave-tucker
dave-tucker previously approved these changes Mar 8, 2019
View reviewed changes

@dave-tuckerdave-tucker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere
Add initial script for docker/app cli-plugin
43bf924
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
duhruh
duhruh approved these changes Mar 8, 2019
View reviewed changes

@duhruhduhruh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKS GREAT 😺

StefanScherer
StefanScherer approved these changes Mar 8, 2019
View reviewed changes

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere
seemethere merged commit bc1e358 into docker:masterMar 8, 2019
@seemethere
seemethere deleted the add_ploogins branch March 8, 2019 19:30
@teohhanhuiteohhanhui mentioned this pull request Nov 25, 2019
Closed
@HeroCCHeroCC mentioned this pull request Jan 14, 2020
Closed
@tianontianon mentioned this pull request May 6, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silvin-lubeckisilvin-lubeckiAwaiting requested review from silvin-lubecki
4 more reviewers
@StefanSchererStefanSchererStefanScherer approved these changes
@russellcardullorussellcardullorussellcardullo approved these changes
@duhruhduhruhduhruh approved these changes
@dave-tuckerdave-tuckerdave-tucker left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seemethere@StefanScherer@russellcardullo@duhruh@dave-tucker