Uh oh!
There was an error while loading. Please reload this page.
[master] Add build target for ubuntu-eoan - #412
Merged
Conversation
Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
arkodg
commented
Dec 6, 2019
Author
thaJeztah
commented
Dec 10, 2019
Member
seemethere
left a comment
Contributor
There was a problem hiding this comment.
Nothing really uses this variable, while adding it here is good the main source of truth of what eventually gets built isn’t in this repository. That should be in release-packaging
arkodg
commented
Dec 10, 2019
Author
@seemethere thanks for the hint . I'm guessing this PR needs to get merged and another PR similar to https://github.com/docker/release-packaging/pull/318 needs to be raised in |
seemethere
commented
Dec 10, 2019
Contributor
I can’t see that PR but yes I’m assuming that’s the correct assumption. |
zelahi
approved these changes
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arko Dasgupta arko.dasgupta@docker.com