Skip to content

[master] Remove some remnants related to image-based builds - #420

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove_activate_remnants
Jan 21, 2020
Merged

[master] Remove some remnants related to image-based builds#420
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove_activate_remnants

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Jan 21, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Looks like these were left behind in #411

relates to docker/cli#2213

@thaJeztah
Remove some remnants related to image-based builds
ca70795
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah mentioned this pull request Jan 21, 2020
Closed
8 tasks
@thaJeztah

thaJeztah commented Jan 21, 2020

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki@StefanScherer@seemethere PTAL

StefanScherer
StefanScherer approved these changes Jan 21, 2020
View reviewed changes

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Jan 21, 2020

Copy link
Copy Markdown
MemberAuthor

I'll go ahead and merge this one

@thaJeztah
thaJeztah merged commit 7730ce0 into docker:masterJan 21, 2020
@thaJeztah
thaJeztah deleted the remove_activate_remnants branch January 21, 2020 20:52
silvin-lubecki
silvin-lubecki reviewed Jan 22, 2020
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thaJeztahthaJeztah mentioned this pull request Jan 22, 2020
Merged
@gloursglours mentioned this pull request Apr 14, 2020
Merged
@thaJeztahthaJeztah changed the title Remove some remnants related to image-based builds[master] Remove some remnants related to image-based buildsMay 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@silvin-lubeckisilvin-lubeckisilvin-lubecki left review comments
@StefanSchererStefanSchererStefanScherer approved these changes
@seemethereseemethereseemethere approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@StefanScherer@seemethere@silvin-lubecki