Uh oh!
There was an error while loading. Please reload this page.
[master] Makefile: use shallow clone - #473
Merged
Merged
Conversation
thaJeztah
commented
May 28, 2020
MemberAuthor
opened as a separate draft, because we had some issues with a similar change in the containerd packaging repository, so this might need some more work |
AkihiroSuda
commented
Jun 8, 2020
Contributor
Does github support shallow-cloning non-HEAD commit? |
AkihiroSuda
commented
Jun 8, 2020
Contributor
Ah, seems supported very recently: https://stackoverflow.com/questions/31278902/how-to-shallow-clone-a-specific-commit-with-depth-1#comment108853566_43136160 |
Before this change: make clean time make checkout git clone -q "https://github.com/docker/cli.git" src/github.com/docker/cli git clone -q "https://github.com/docker/docker.git" src/github.com/docker/docker 69.16 real 15.69 user 9.69 sys After this change: make clean time make checkout ... From https://github.com/docker/docker * branch HEAD -> FETCH_HEAD git -C src/github.com/docker/docker checkout -q FETCH_HEAD 14.73 real 1.35 user 2.37 sys Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
fetching a tag ref does not download the tag itself. This patch makes sure that the tag (or branch) is downloaded otherwise fallsback to fetching the commit hash as it did before. Co-Authored-By: Tibor Vass <tibor@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
marked this pull request as ready for review
August 1, 2020 16:15
thaJeztah
commented
Aug 3, 2020
MemberAuthor
Yes, correct, it wasn't supported in the past, but now is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #457
Before this change:
After this change: