Skip to content

[master] plugins: don't require "experimental" for buildx - #490

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:buildx_remove_experimental_gate
Aug 5, 2020
Merged

[master] plugins: don't require "experimental" for buildx#490
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:buildx_remove_experimental_gate

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Aug 4, 2020

Copy link
Copy Markdown
Member

Some features of buildx may still be "experimental" / non-final, but we can call those out individually if needed.

This change removes the requirement to enable "experimental" mode in the cli configuration file, so that it's easier for users to try buildx.

@thaJeztah
plugins: don't require "experimental" for buildx
0b45cce
Some features of buildx may still be "experimental" / non-final,
but we can call those out individually if needed.
This change removes the requirement to enable "experimental" mode
in the cli configuration file, so that it's easier for users to
try buildx.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

thaJeztah commented Aug 4, 2020

Copy link
Copy Markdown
MemberAuthor

@tonistiigi@tiborvass@chris-crone@silvin-lubecki PTAL

chris-crone
chris-crone approved these changes Aug 4, 2020
View reviewed changes

@chris-cronechris-crone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should update the buildx README too

@hakman

hakman commented Aug 4, 2020

Copy link
Copy Markdown

Somewhat related, any thoughts about docker manifest? Will it be removed or maybe become non-experimental too?

@thaJeztah

thaJeztah commented Aug 4, 2020

Copy link
Copy Markdown
MemberAuthor

Still being discussed; we may remove the "experimental" requirement itself, but there's still (UX) issues with those subcommands that should be looked into, so they may still be marked "experimental" (in the documentation), to indicate that backward-compatibility of the commands is not guaranteed.

@thaJeztah

thaJeztah commented Aug 4, 2020

Copy link
Copy Markdown
MemberAuthor

We should update the buildx README too

@chris-crone yes, I had that one open in a tab; should be updated that starting with 20.x it's not needed to set the configuration (unless we decide to backport this change to 19.03, in which case the patch release version should be mentioned)

silvin-lubecki
silvin-lubecki approved these changes Aug 4, 2020
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@thaJeztah
thaJeztah merged commit ddab5d3 into docker:masterAug 5, 2020
@thaJeztah
thaJeztah deleted the buildx_remove_experimental_gate branch August 5, 2020 21:28
@thaJeztahthaJeztah changed the title plugins: don't require "experimental" for buildx[master] plugins: don't require "experimental" for buildxAug 8, 2020
@thaJeztahthaJeztah mentioned this pull request Jun 2, 2021
Closed
rgl added a commit to rgl/example-docker-buildx-go that referenced this pull request Jun 28, 2021
@rgl
upgrade to docker 20.10.7
b960e5a
since docker 20.10 buildx is no longer experimental
see docker/docker-ce-packaging#490
@LudeaLudea mentioned this pull request Apr 8, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-cronechris-cronechris-crone approved these changes
+1 more reviewer
@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@hakman@chris-crone@silvin-lubecki