[master] update buildx to v0.6.0

[thaJeztah]

release notes: https://github.com/docker/buildx/releases/tag/v0.6.0

Signed-off-by: Sebastiaan van Stijn github@gone.nl

[thaJeztah]

@tonistiigi@crazy-max ptal

[thaJeztah]

Should this go into 20.10 as well? If so, we should cherry-pick this one after it's merged

[thaJeztah]

Looks like the build is broken for v0.6.0;

+ GOFLAGS=-mod=vendor
+ go build -o bin/docker-buildx -ldflags '-X github.com/docker/buildx/version.Version=v0.6.0-docker -X github.com/docker/buildx/version.Revision=d9ee3b134cbc2d09513fa7fee4176a3919e05887 -X github.com/docker/buildx/version.Package=github.com/docker/buildx' ./cmd/buildx
vendor/github.com/moby/buildkit/client/client.go:20:2: code in directory /go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/tracing/otlptracegrpc expects import "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/connection/connection.go:33:2: found import comments "go.opentelemetry.io/otel/exporters/otlp/internal/otlpconfig" (options.go) and "go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig" (optiontypes.go) in /go/src/github.com/docker/buildx/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig

[thaJeztah]

Interesting; if GO111MODULE is not set (but GOFLAGS=-mod=vendor), then it builds successfully:

echo$GO111MODULEexport LDFLAGS="-X ${PKG}/version.Version=$(git describe --match 'v[0-9]*' --always --tags)-docker -X ${PKG}/version.Revision=$(git rev-parse HEAD) -X ${PKG}/version.Package=${PKG}"
GOFLAGS=-mod=vendor go build -o bin/docker-buildx -ldflags "${LDFLAGS}" ./cmd/buildx
bin/docker-buildx version
github.com/docker/buildx v0.6.0-docker d9ee3b134cbc2d09513fa7fee4176a3919e05887

Byt with GO111MODULE=off, it fails on the incorrect import path somewhere in a vendored file:

export GO111MODULE=off
root@5a55ec1c1eed:/go/src/github.com/docker/buildx# GOFLAGS=-mod=vendor go build -o bin/docker-buildx -ldflags "${LDFLAGS}" ./cmd/buildx
vendor/github.com/moby/buildkit/client/client.go:20:2: code in directory /go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/tracing/otlptracegrpc expects import "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/connection/connection.go:33:2: found import comments "go.opentelemetry.io/otel/exporters/otlp/internal/otlpconfig" (options.go) and "go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig" (optiontypes.go) in /go/src/github.com/docker/buildx/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig

https://github.com/docker/buildx/blob/v0.6.0/vendor/github.com/moby/buildkit/client/client.go#L20

And looking at the code it imports, that indeed looks to have an (incorrect) import path; https://github.com/docker/buildx/blob/v0.6.0/vendor/github.com/moby/buildkit/util/tracing/otlptracegrpc/client.go#L15

package otlptracegrpc // import "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"

[crazy-max]

LGTM

[silvin-lubecki]

LGTM