Skip to content

WIP: Networking support - #729

Merged
shin- merged 1 commit into
docker:masterfrom
aanand:networking
Oct 8, 2015
Merged

WIP: Networking support#729
shin- merged 1 commit into
docker:masterfrom
aanand:networking

Conversation

@aanand

Copy link
Copy Markdown
Contributor

A whole bunch of new Client methods which bind to the experimental networking API (here's an overview of the functionality it offers).

@abronanabronan mentioned this pull request Aug 28, 2015
@aanand
aanandforce-pushed the networking branch 2 times, most recently from 5f53418 to 2b7ae4dCompareSeptember 23, 2015 15:36
@aanand

Copy link
Copy Markdown
ContributorAuthor

This is ready for more eyes.

The networking API doesn't appear to be present in Docker master (which is strange - @mavenugo, @dave-tucker, is that expected? When should it land?), so to test it you'll need to install experimental Docker. If not straightforward per se, it's at least fairly doable with Docker Machine:

docker-machine create -d virtualbox experimental
docker-machine ssh experimental 'sudo sh -c "set -ex; /etc/init.d/docker stop || true; sleep 2; curl https://experimental.docker.com/builds/Linux/x86_64/docker-1.9.0-dev > /usr/local/bin/docker; /etc/init.d/docker start"'
eval "$(docker-machine env experimental)"

Then update DEFAULT_DOCKER_API_VERSION to '1.21' in docker/constants.py.

Finally, run the tests:

make unit-test
make integration-test

There are unrelated failures in both test suites, caused by the version update.

@mavenugo

Copy link
Copy Markdown

@aanand yes. the API has not landed into docker proper yet. It is still under experimental. We are waiting on a few fixes to be merged before moving the API/UX out of experimental.

Comment threaddocker/api/network.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use self._url('/networks/{0}', resource_id=net_id) instead to avoid URL tampering

@aanand

Copy link
Copy Markdown
ContributorAuthor

This is now working against the latest iteration of the networking API, as implemented in moby/moby#16645.

@shin-

shin- commented Oct 2, 2015

Copy link
Copy Markdown
Contributor

👍

@aanand
aanandforce-pushed the networking branch 3 times, most recently from ac3206c to c74baf7CompareOctober 5, 2015 15:46
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@aanand@mavenugo@shin-