Uh oh!
There was an error while loading. Please reload this page.
Update the test_inspect_network - #888
Merged
Merged
Conversation
wenchma
commented
Dec 29, 2015
Author
This PR and moby/moby#18928 depend on each other, so it will block each other. I workaround it that firstly we remove |
wenchmaforce-pushed
the
18626-sync_inspect_network
branch
from
December 29, 2015 09:09
6b39800 to
bd192e1Compareshin-
commented
Dec 29, 2015
Contributor
Maybe change the test instead so that it tests a few specific values in the result - I would check for the presence (and validity) of |
wenchmaforce-pushed
the
18626-sync_inspect_network
branch
from
December 30, 2015 02:33
bd192e1 to
59e7242Comparewenchmaforce-pushed
the
18626-sync_inspect_network
branch
2 times, most recently
from
December 30, 2015 02:42
ae97fab to
c424148Compare
This is based on moby/moby#18928 Related to moby/moby#18626 Signed-off-by: Wen Cheng Ma <wenchma@cn.ibm.com>
wenchma
commented
Dec 30, 2015
Author
@shin- good idea, 👍 already updated the PR to cover only a few specific values. |
shin-
commented
Jan 5, 2016
Contributor
Thanks - LGTM! |
wenchma pushed a commit
to wenchma/docker
that referenced
this pull request
Jan 15, 2016
* If user doesn't specify the subnets to create a network, it will pick subnets from inside preferred pool. This PR aims to inspect these subnets info * Add integration tests for docker inspect the subnets. * docker-py project is already synchronized. * jenkins checks depend on docker/docker-py#888 Fixes issue moby#18626 Signed-off-by: Wen Cheng Ma <wenchma@cn.ibm.com>
aditirajagopal pushed a commit
to aditirajagopal/docker
that referenced
this pull request
Feb 8, 2016
* If user doesn't specify the subnets to create a network, it will pick subnets from inside preferred pool. This PR aims to inspect these subnets info * Add integration tests for docker inspect the subnets. * docker-py project is already synchronized. * jenkins checks depend on docker/docker-py#888 Fixes issue moby#18626 Signed-off-by: Wen Cheng Ma <wenchma@cn.ibm.com>
tiborvass pushed a commit
to tiborvass/cli
that referenced
this pull request
May 11, 2017
* If user doesn't specify the subnets to create a network, it will pick subnets from inside preferred pool. This PR aims to inspect these subnets info * Add integration tests for docker inspect the subnets. * docker-py project is already synchronized. * jenkins checks depend on docker/docker-py#888 Fixes issue #18626 Signed-off-by: Wen Cheng Ma <wenchma@cn.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is depended by moby/moby#18928
Related to moby/moby#18626
Signed-off-by: Wen Cheng Ma wenchma@cn.ibm.com