Skip to content

Add info on ssh agent usage - #10184

Merged
usha-mandya merged 4 commits into
docker:masterfrom
usha-mandya:desktop-1928
Jan 30, 2020
Merged

Add info on ssh agent usage#10184
usha-mandya merged 4 commits into
docker:masterfrom
usha-mandya:desktop-1928

Conversation

@usha-mandya

@usha-mandyausha-mandya commented Jan 23, 2020

Copy link
Copy Markdown
Member

Proposed changes

Added info on how users can access the host's SSH agent inside containers.

Related issues (optional)

https://docker.atlassian.net/browse/DESKTOP-1928

@GordonTheTurtle

GordonTheTurtle commented Jan 23, 2020•
edited
Loading

Copy link
Copy Markdown

Deploy preview for docsdocker ready!

Built with commit 5b34e1a

https://deploy-preview-10184--docsdocker.netlify.com

AkihiroSuda
AkihiroSuda reviewed Jan 23, 2020
View reviewed changes
Comment threaddocker-for-mac/faqs.md Outdated
mat007
mat007 previously approved these changes Jan 24, 2020
View reviewed changes

@mat007mat007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

guillaumerose
guillaumerose previously approved these changes Jan 24, 2020
View reviewed changes
@usha-mandya
usha-mandya dismissed stale reviews from guillaumerose and mat007 via 5b34e1aJanuary 27, 2020 12:01
@usha-mandya

usha-mandya commented Jan 27, 2020

Copy link
Copy Markdown
MemberAuthor

Moved the details to the 'Networking' topic to avoid cluttering the FAQ page with instructions.

mat007
mat007 previously approved these changes Jan 27, 2020
View reviewed changes

@mat007mat007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

thaJeztah
thaJeztah reviewed Jan 27, 2020
View reviewed changes
Comment threaddocker-for-mac/networking.md Outdated
Comment threaddocker-for-mac/networking.md Outdated
Comment threaddocker-for-mac/networking.md Outdated
@usha-mandya

usha-mandya commented Jan 28, 2020

Copy link
Copy Markdown
MemberAuthor

@thaJeztah@guillaumerose@mat007 Thanks for your review. I've updated the topic based on the suggestions noted above. PTAL.

mat007
mat007 previously approved these changes Jan 28, 2020
View reviewed changes
Comment threaddocker-for-mac/faqs.md Outdated
thaJeztah
thaJeztah approved these changes Jan 29, 2020
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threaddocker-for-mac/osxfs.md
Comment threaddocker-for-mac/faqs.md
@usha-mandya
usha-mandya merged commit 4dc6844 into docker:masterJan 30, 2020
@usha-mandya
usha-mandya deleted the desktop-1928 branch January 30, 2020 17:24
@thaJeztahthaJeztah mentioned this pull request Oct 20, 2020
Merged
@thaJeztahthaJeztah mentioned this pull request May 10, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztahthaJeztahthaJeztah approved these changes
@mat007mat007mat007 left review comments
+2 more reviewers
@AkihiroSudaAkihiroSudaAkihiroSuda left review comments
@guillaumeroseguillaumeroseguillaumerose approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@usha-mandya@GordonTheTurtle@guillaumerose@thaJeztah@mat007@AkihiroSuda