Skip to content

config: remove docs.docker.com as site URL - #10477

Merged
usha-mandya merged 1 commit into
docker:masterfrom
thaJeztah:remove_fixed_domain
Mar 20, 2020
Merged

config: remove docs.docker.com as site URL#10477
usha-mandya merged 1 commit into
docker:masterfrom
thaJeztah:remove_fixed_domain

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Mar 18, 2020

Copy link
Copy Markdown
Member

extracting this from #10471

Having this variable set causes redirects to always redirect to https://docs.docker.com, which makes it not possible to preview redirects locally, or to host them on a different domain (e.g. on a staging domain).

@thaJeztah
config: remove docs.docker.com as site URL
7fbb657
Having this variable set causes redirects to always redirect to
https://docs.docker.com, which makes it not possible to preview
redirects locally, or to host them on a different domain (e.g.
on a staging domain).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

thaJeztah commented Mar 18, 2020

Copy link
Copy Markdown
MemberAuthor

@StefanScherer@usha-mandya PTAL; please double-check if this has no side-effects. I couldn't find any, but perhaps may have missed some

@usha-mandya

usha-mandya commented Mar 19, 2020

Copy link
Copy Markdown
Member

Can't think of any issues arising due to this change. @StefanScherer Any thoughts?

StefanScherer
StefanScherer approved these changes Mar 19, 2020
View reviewed changes

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanScherer

StefanScherer commented Mar 19, 2020

Copy link
Copy Markdown
Member

Looking forward to test this in docs-test website.
Currently if I want to open this old doc https://docs-test.docker.com/v17.03/engine/admin/volumes/ it 301 forwards to https://docs-test.docker.com/engine/admin/volumes/ and then links to https://docs.docker.com/storage/ leaving the docs-test.docker.com website.
Maybe this is fixed after merging this PR?

@usha-mandya
usha-mandya merged commit 5796c76 into docker:masterMar 20, 2020
@thaJeztah
thaJeztah deleted the remove_fixed_domain branch March 20, 2020 10:16
@StefanScherer

StefanScherer commented Mar 20, 2020

Copy link
Copy Markdown
Member

Yes, the non existing page https://docs-test.docker.com/v17.03/engine/admin/volumes/ is now redirected to https://docs-test.docker.com/storage/ 🎉

@usha-mandya

usha-mandya commented Mar 20, 2020

Copy link
Copy Markdown
Member

Thanks Stefan!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanSchererStefanSchererStefanScherer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@usha-mandya@StefanScherer