Uh oh!
There was an error while loading. Please reload this page.
compose-file: add some options that were missing in changes - #10680
Merged
Conversation
thaJeztahforce-pushed
the
compose_build_network
branch
from
April 21, 2020 18:56
dfb7338 to
0e43307CompareSigned-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
compose_build_network
branch
from
April 21, 2020 18:57
0e43307 to
3caa2caCompareDeploy preview for docsdocker ready! Built with commit dfb7338 |
Deploy preview for docsdocker ready! Built with commit 3caa2ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the
networkoption for build was not documented, which was added in compose-file 2.2 (docker/compose#4997) and 3.4 (docker/cli#430), then saw some missing entries for the v3.1 and v3.2 format, so added those (probably more changes may be needed, but it didn't go through all versions)@usha-mandya@ulyssessouza PTAL