Skip to content

Desktop: release notes: mention kernel update and performance fix - #13351

Merged
usha-mandya merged 1 commit into
docker:masterfrom
thaJeztah:update_dd_releasenotes
Aug 16, 2021
Merged

Desktop: release notes: mention kernel update and performance fix#13351
usha-mandya merged 1 commit into
docker:masterfrom
thaJeztah:update_dd_releasenotes

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Aug 14, 2021

Copy link
Copy Markdown
Member

@thaJeztahthaJeztah added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Aug 14, 2021
@thaJeztah

thaJeztah commented Aug 14, 2021

Copy link
Copy Markdown
MemberAuthor

@StefanScherer@fredericdalleau PTAL

Should we add the description to the "for win" release notes as well? Not sure if we received reports from Windows users, but if it's a kernel issue, I assume those would be equally affected?

@thaJeztahthaJeztah mentioned this pull request Aug 14, 2021
Closed
3 tasks
@netlify

netlifyBot commented Aug 14, 2021•
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 4cae233

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/611a4803b84254000781364b

😎 Browse the preview: https://deploy-preview-13351--docsdocker.netlify.app

@thaJeztahthaJeztah mentioned this pull request Aug 14, 2021
Merged
@StefanScherer

StefanScherer commented Aug 16, 2021

Copy link
Copy Markdown
Member

@thaJeztah Yes, we can add the same description to the docker-for-win/release-notes.md

@thaJeztah
thaJeztahforce-pushed the update_dd_releasenotes branch from c32dae8 to c37f85eCompareAugust 16, 2021 08:24
@thaJeztah

thaJeztah commented Aug 16, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks @StefanScherer - updated; added the note to the Windows release notes as well 👍

StefanScherer
StefanScherer previously approved these changes Aug 16, 2021
View reviewed changes

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@thaJeztah

thaJeztah commented Aug 16, 2021

Copy link
Copy Markdown
MemberAuthor

FWIW: If we are good with #13353, I think rebasing this after that one will be easier (git should in most cases automatically pick up the renamed files)

We should check if updating the URLs without changing the URLs in Docker Desktop will be a problem though (if they all open in a browser, the browser should redirect as usual)

@thaJeztah
thaJeztahforce-pushed the update_dd_releasenotes branch from c37f85e to ba641c3CompareAugust 16, 2021 10:59
@thaJeztah

thaJeztah commented Aug 16, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased, as #13353 was merged 👍

usha-mandya
usha-mandya reviewed Aug 16, 2021
View reviewed changes
Comment threaddesktop/mac/release-notes.md Outdated
usha-mandya
usha-mandya reviewed Aug 16, 2021
View reviewed changes
Comment threaddesktop/windows/release-notes.md Outdated
@usha-mandya

usha-mandya commented Aug 16, 2021

Copy link
Copy Markdown
Member

@thaJeztah Left a minor suggestion. Looks good otherwise.

@thaJeztah
Desktop: release notes: mention kernel update and performance fix
4cae233
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the update_dd_releasenotes branch from ba641c3 to 4cae233CompareAugust 16, 2021 11:12
@thaJeztah

thaJeztah commented Aug 16, 2021

Copy link
Copy Markdown
MemberAuthor

Updated! Thanks for reviewing 🤗

StefanScherer
StefanScherer approved these changes Aug 16, 2021
View reviewed changes

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya
usha-mandya merged commit a6e5434 into docker:masterAug 16, 2021
@thaJeztah
thaJeztah deleted the update_dd_releasenotes branch August 16, 2021 11:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanSchererStefanSchererStefanScherer approved these changes
@usha-mandyausha-mandyausha-mandya approved these changes

Assignees

No one assigned

Labels

area/desktopIssue affects a desktop edition of Docker. E.g docker for mac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@StefanScherer@usha-mandya