Uh oh!
There was an error while loading. Please reload this page.
Add missing code-hints, and minor markdown edits - #13352
Merged
Merged
Conversation
thaJeztahforce-pushed
the
add_missing_codehints
branch
from
August 14, 2021 12:48
13221c4 to
5d9e941Compare
This comment has been minimized.
This comment has been minimized.
thaJeztahforce-pushed
the
add_missing_codehints
branch
2 times, most recently
from
August 14, 2021 12:55
6a216a6 to
691aa55Compare
This comment has been minimized.
This comment has been minimized.
thaJeztahforce-pushed
the
add_missing_codehints
branch
from
August 14, 2021 12:57
691aa55 to
b3750edCompare✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 691aa55 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6117bd2644e608000878f4a2 😎 Browse the preview: https://deploy-preview-13352--docsdocker.netlify.app |
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 1583678 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/611a45147e05ef00077295bd 😎 Browse the preview: https://deploy-preview-13352--docsdocker.netlify.app |
thaJeztah
commented
Aug 14, 2021
MemberAuthor
thaJeztahforce-pushed
the
add_missing_codehints
branch
from
August 14, 2021 13:15
b3750ed to
12c9de1ComparethaJeztah
commented
Aug 16, 2021
MemberAuthor
FWIW: If we are good with #13353, I think rebasing this after that one will be easier (git should in most cases automatically pick up the renamed files) |
- Add missing code-hints (console, yaml) - Consistently add an empty line after code-blocks - Combine some examples where the output and the command were put in separate blocks. With the "console" code-hint, this is no longer nescessary. - fix indentation in cloud/ecs-integration.md, which caused the numbered-list to be interrupted. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
add_missing_codehints
branch
from
August 16, 2021 10:59
12c9de1 to
1583678ComparethaJeztah
commented
Aug 16, 2021
MemberAuthor
Rebased, as #13353 was merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foillow-up to #13299