Skip to content

engine: add known issues to 20.10.15 release notes - #14708

Merged
usha-mandya merged 1 commit into
docker:masterfrom
thaJeztah:engine_known_issues
May 11, 2022
Merged

engine: add known issues to 20.10.15 release notes#14708
usha-mandya merged 1 commit into
docker:masterfrom
thaJeztah:engine_known_issues

Conversation

@thaJeztah

@thaJeztahthaJeztah commented May 10, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@thaJeztahthaJeztah added the area/engine Issue affects Docker engine/daemon label May 10, 2022
@thaJeztah

thaJeztah commented May 10, 2022

Copy link
Copy Markdown
MemberAuthor

@usha-mandya@dockertopia ptal

@netlify

netlifyBot commented May 10, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

NameLink
🔨 Latest commit6714825
🔍 Latest deploy loghttps://app.netlify.com/sites/docsdocker/deploys/627a5104fa1f0d0009670c15
😎 Deploy Previewhttps://deploy-preview-14708--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thaJeztahthaJeztah mentioned this pull request May 10, 2022
Merged
1 task
dockertopia
dockertopia reviewed May 10, 2022
View reviewed changes

@dockertopiadockertopia left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a few minor suggestions.

Comment threadengine/release-notes/index.md Outdated
Comment threadengine/release-notes/index.md Outdated
Comment threadengine/release-notes/index.md Outdated
@thaJeztah
thaJeztahforce-pushed the engine_known_issues branch from 6dc0d92 to 35ef1dfCompareMay 10, 2022 11:08
@thaJeztah

thaJeztah commented May 10, 2022

Copy link
Copy Markdown
MemberAuthor

Updated with your suggestions; changed the fix for the link to use fix for this issue (instead of the "has been merged"); PTAL if this looks good to you 🤗

Screenshot 2022-05-10 at 13 08 08

@usha-mandya

usha-mandya commented May 10, 2022

Copy link
Copy Markdown
Member

Thanks @thaJeztah. Looks good. There's a broken link to the Extensions doc which isnt part of this PR. I've re-run the failed jobs to see if that fixes any issues.

@thaJeztah
engine: add known issues to 20.10.15 release notes
6714825
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the engine_known_issues branch from 35ef1df to 6714825CompareMay 10, 2022 11:48
@thaJeztah

thaJeztah commented May 10, 2022

Copy link
Copy Markdown
MemberAuthor

Bleh.. looks to be still failing; broken link may be in the external repository though;

- ./_site/desktop/extensions-sdk/extensions/labels/index.html
Ran on 1666 files!
* linking to internal hash #design-principles that does not exist (line 197)
<a href="../../design/design-overview/#design-principles">CSS guidlines</a>

@thaJeztah

thaJeztah commented May 11, 2022

Copy link
Copy Markdown
MemberAuthor

Fix for the above is in docker/extensions-sdk#160

usha-mandya
usha-mandya approved these changes May 11, 2022
View reviewed changes

@usha-mandyausha-mandya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya
usha-mandya merged commit 032837c into docker:masterMay 11, 2022
@thaJeztah
thaJeztah deleted the engine_known_issues branch May 11, 2022 12:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@usha-mandyausha-mandyausha-mandya approved these changes
+1 more reviewer
@dockertopiadockertopiadockertopia left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/engineIssue affects Docker engine/daemon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@usha-mandya@dockertopia