Uh oh!
There was an error while loading. Please reload this page.
[build-docs] build: create Docker Build section - #14880
Merged
Merged
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
dockertopia
self-requested a review
June 3, 2022 12:53
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
dockertopia
approved these changes
Jun 3, 2022
dockertopia
left a comment
Contributor
There was a problem hiding this comment.
As discussed, work on branch using agreed flow will follow. 👍
crazy-max
commented
Jun 3, 2022
MemberAuthor
Let's merge this one to see if deployment on Netlify looks good. |
crazy-max
commented
Jun 3, 2022
MemberAuthor
Looks good: https://build-docs--docsdocker.netlify.app/build/ !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #14642
as discussed with @dockertopia we have created a dedicated build-docs branch so we can iterate changes over this one and when everything looks good on this branch, merge it to master.
Each PR targeting the build-docs branch should have
[build-docs]as title prefix.I have added this branch to netlify deployment so we will able to have an overview of the current progress:
Changes will be visible at https://build-docs--docsdocker.netlify.app/
cc @dockertopia@chris-crone@tonistiigi@thaJeztah@usha-mandya
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com